#205 - Fix FileSplitterTask - #216
Merged
Merged
Conversation
…ne, doubled line breaks and ended with an empty file; each file now contains exactly `max_lines` lines of the source. Update documentation, add tests. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #205.
FileSplitterTaskdoes not split the source file correctly:The produced files contain neither
max_lineslines of the input nor the original content.This PR:
max_lineslines per file (the last one fewer), stripping only the trailing\r\n/\nof each line beforewriteLine(): no line is lost, content is preserved, line breaks are not doubled.next()stops as soon as no line is left, so no empty file is emitted; an empty source file is skipped and produces no output.The new regression tests fail on
mainand pass with this fix. PHPUnit, PHPStan, PHP-CS-Fixer and Rector pass.Requirements
Breaking changes
None: this fixes the content of the produced files (the task was introduced in v5.0, #174). Line breaks in produced files are written as
PHP_EOL, and an empty source file now produces no output instead of an empty file.🤖 Generated with Claude Code