Repository navigation
chore: update OpenAPI to 650bd71c22db - #541
ant-release-bot wants to merge 1 commit into
Conversation
|
LGTM |
![clanky-the-clanker[bot]](https://avatars.githubusercontent.com/in/5306670?s=60&v=4){kind=small}
There was a problem hiding this comment.
Superseded by the review of
c9e1760b.
This review, of b4de6379
✅ Approved — The change is a one-line OpenAPI pin bump plus a changeset. The pin is consistent across the title, description and changeset, and I found no issues.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code Quality: ✅ LGTM
The pin bump is consistent with the changeset and the pull request description. No other references to the old revision remain, apart from an older changeset that should stay.
Reviewed commit: b4de6379
|
| mean | stddev | min | max | |
|---|---|---|---|---|
| PR | 259.0 ms | 4.4 ms | 251.5 ms | 267.4 ms |
| base | 254.9 ms | 4.3 ms | 249.7 ms | 263.0 ms |
Δ (PR vs base): ↑ +4.1 ms (+1.6%)
Measured with hyperfine on ubuntu-latest (3 warmup runs, 20 timed runs). CI numbers carry ±a few ms of runner jitter; treat small deltas as noise.
ant-release-bot
changed the title
b4de637 to
c9e1760
Compare
|
LGTM! |
commit: |
There was a problem hiding this comment.
Superseded by the review of
26bc757a.
This review, of c9e1760b
💬 Approved with comments — The regeneration is consistent with the pinned revision. One WARNING: the changeset doesn't call out the removal of --page/--per-page from two list commands, which .changeset/README.md requires for breaking changes during the beta.
Findings: 1 warning (1 is an inline comment on the diff)
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
🔧 Fix with your agent
Paste the following into your coding agent to investigate and fix these issues.
Fix the following code review issues found in pull request #541.
Before making changes, review each issue and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g., the fix would require disproportionate changes
for minimal ROI, or the finding is factually incorrect), explain why
- If you need to clarify something before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
## WARNING (1)
### [Release] The changeset doesn't call out that `--page`/`--per-page` were removed from `cf organizations accounts list` and `cf tenants accounts list`, as `.changeset/README.md:33-34` requires for breaking changes.
- **File:** .changeset/update-openapi-21b40a3c550e.md:5
🚀 Release: ⚠️ 1 warning
The changeset doesn't call out the removal of the legacy pagination flags, which breaks existing scripts.
Recommendation: 📝 Minor Comments
- [WARNING] The changeset doesn't call out that
--page/--per-pagewere removed fromcf organizations accounts listandcf tenants accounts list, as.changeset/README.md:33-34requires for breaking changes. (.changeset/update-openapi-21b40a3c550e.md:5)
View full review
cf organizations accounts list and cf tenants accounts list no longer accept --page / --per-page; see packages/cli/src/commands/_generated/organizations/accounts/list.ts:87-92 and the matching tenants file. Strict yargs rejects unknown options, so existing invocations that use these flags will fail. .changeset/README.md:33-34 requires breaking changes during the 1.0 beta to go in minor bumps and to be called out explicitly. The bump is minor, but the changeset body doesn't mention the removal or the cursor-pagination replacement.
✅ All other checks passed
🔒 Security: ✅ LGTM
No security concerns in this regeneration.
📖 AGENTS.md: ✅ LGTM
No issues found.
📋 Code Quality: ✅ LGTM
The pin in generate.ts, the generated command and operation files, and the _meta JSON all match each other. No tests reference the removed flags.
⚡ Performance: ✅ LGTM
Generated code only. It adds no new requests, loops or I/O.
📝 Documentation: ✅ LGTM
No issues found.
Reviewed commit: c9e1760b
| Update the generated command surface for Forge OpenAPI release | ||
| `21b40a3c550e19972843a3eb62c274a1707b317b`. |
There was a problem hiding this comment.
The changeset doesn't call out that --page/--per-page were removed from cf organizations accounts list and cf tenants accounts list, as .changeset/README.md:33-34 requires for breaking changes.
This regeneration removes the legacy --page and --per-page options from cf organizations accounts list and cf tenants accounts list. Strict yargs will reject them, so existing scripts that use offset pagination will fail. .changeset/README.md says breaking changes during the 1.0 beta must be called out explicitly. Name the removed flags here and point users to --page-token / --page-size so the change shows up in the release notes.
| Update the generated command surface for Forge OpenAPI release | |
| `21b40a3c550e19972843a3eb62c274a1707b317b`. | |
| Update the generated command surface for Forge OpenAPI release | |
| `21b40a3c550e19972843a3eb62c274a1707b317b`. | |
| Breaking: `cf organizations accounts list` and `cf tenants accounts list` no | |
| longer accept the legacy `--page` and `--per-page` offset-pagination flags. Use | |
| `--page-token` and `--page-size` for cursor pagination instead. |
ant-release-bot
changed the title
c9e1760 to
26bc757
Compare
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
| Update the generated command surface for Forge OpenAPI release | ||
| `07fc9fa430cd323d7cd421a5c094e2a0109f1f7e`. |
There was a problem hiding this comment.
This regeneration removes --page and --per-page from both account-list commands, so scripts using offset pagination now fail strict option validation. During the 1.0 beta, .changeset/README.md requires breaking changes to be called out explicitly.
| Update the generated command surface for Forge OpenAPI release | |
| `07fc9fa430cd323d7cd421a5c094e2a0109f1f7e`. | |
| Update the generated command surface for Forge OpenAPI release | |
| `650bd71c22db3b938a4611bf4cc5afd896b400b7`. | |
| Breaking: `cf organizations accounts list` and `cf tenants accounts list` no | |
| longer accept the legacy `--page` and `--per-page` offset-pagination flags. Use | |
| `--page-token` and `--page-size` for cursor pagination instead. |
|
Review: 1 findings. Posted 1 inline suggestion for the undocumented breaking pagination-flag removal. |
There was a problem hiding this comment.
Superseded by the review of
3b2db032.
This review, of 26bc757a
💬 Approved with comments — The regeneration is consistent. One WARNING is still open from the last review: the changeset doesn't call out that two list commands lost their --page/--per-page flags, which .changeset/README.md requires for breaking changes during the beta.
Findings: 1 warning (1 is an inline comment on the diff)
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
🔧 Fix with your agent
Paste the following into your coding agent to investigate and fix these issues.
Fix the following code review issues found in pull request #541.
Before making changes, review each issue and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g., the fix would require disproportionate changes
for minimal ROI, or the finding is factually incorrect), explain why
- If you need to clarify something before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
## WARNING (1)
### [Release] The changeset doesn't call out that `--page`/`--per-page` were removed from `cf organizations accounts list` and `cf tenants accounts list`, which `.changeset/README.md:33-34` requires for beta breaking changes.
- **File:** .changeset/update-openapi-07fc9fa430cd.md:5
🚀 Release: ⚠️ 1 warning
The changeset still doesn't call out that two list commands lost their pagination flags.
Recommendation: 📝 Minor Comments
- [WARNING] The changeset doesn't call out that
--page/--per-pagewere removed fromcf organizations accounts listandcf tenants accounts list, which.changeset/README.md:33-34requires for beta breaking changes. (.changeset/update-openapi-07fc9fa430cd.md:5)
View full review
.changeset/update-openapi-07fc9fa430cd.md says only that the generated command surface was updated. It doesn't mention that cf organizations accounts list and cf tenants accounts list no longer accept --page/--per-page (see packages/cli/src/commands/_generated/organizations/accounts/list.ts and the matching tenants file). The commands now use cursor pagination with --page-token/--page-size.
Strict yargs rejects unknown options, so existing invocations that pass the old flags will fail. .changeset/README.md:33-34 says that during the 1.0 beta, breaking changes go in minor bumps and must be called out explicitly. The bump is already minor, so only the body needs to change.
✅ All other checks passed
🔒 Security: ✅ LGTM
No security concerns in this regeneration.
📖 AGENTS.md: ✅ LGTM
No issues found.
📋 Code Quality: ✅ LGTM
The pin in generate.ts matches the revision in the title. The new edit command is registered in zero-trust/organization/index.ts. Its operation file, commands.json and schemas.json agree with each other, and the description-only changes are consistent across the command files and the metadata.
⚡ Performance: ✅ LGTM
Generated code only; it adds no new requests, loops or I/O.
📝 Documentation: ✅ LGTM
No issues found beyond the changeset omission covered in the Release section.
Reviewed commit: 26bc757a
| "cf": minor | ||
| --- | ||
|
|
||
| Update the generated command surface for Forge OpenAPI release |
There was a problem hiding this comment.
The changeset doesn't call out that --page/--per-page were removed from cf organizations accounts list and cf tenants accounts list, which .changeset/README.md:33-34 requires for beta breaking changes.
cf organizations accounts list and cf tenants accounts list no longer accept --page/--per-page. Strict yargs rejects unknown options, so scripts that still pass those flags will fail with an unknown-option error. .changeset/README.md:33-34 requires breaking changes during the 1.0 beta to be called out explicitly. Add a line naming the removed flags and pointing users to --page-token/--page-size; you could also mention the new cf zero-trust organization edit command.
ant-release-bot
changed the title
26bc757 to
3b2db03
Compare
|
Review: 1 findings. Updated the existing ask-bonk pagination compatibility suggestion for the current OpenAPI revision. No additional concerns. |
There was a problem hiding this comment.
💬 Approved with comments — The regeneration is consistent. The only open note is that the changeset should say --page/--per-page were removed from two account-list commands, which .changeset/README.md asks for with breaking changes during the beta.
Findings: 1 info
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
🚀 Release: 💬 1 info
The changeset still doesn't mention that the offset-pagination flags were removed from two commands.
Recommendation: 📝 Minor Comments
- [INFO] The changeset doesn't call out that
--page/--per-pagewere removed fromcf organizations accounts listandcf tenants accounts list, which.changeset/README.md:33-34requires for beta breaking changes. (.changeset/update-openapi-650bd71c22db.md:5)
View full review
.changeset/update-openapi-650bd71c22db.md says only that the generated command surface was updated. Two commands in this pull request no longer accept --page and --per-page: cf organizations accounts list and cf tenants accounts list (see packages/cli/src/commands/_generated/organizations/accounts/list.ts and the matching tenants file). Both now support only cursor pagination, with --page-token and --page-size.
Strict yargs rejects unknown options, so existing invocations that pass the old flags will fail. .changeset/README.md:33-34 says that during the 1.0 beta, breaking changes go in minor bumps and must be called out explicitly. The bump is already minor, so only the body needs to change.
✅ All other checks passed
🔒 Security: ✅ LGTM
No security concerns in this regeneration. The pin is a full commit SHA. The new edit command sends its request only through the shared #api client.
📖 AGENTS.md: ✅ LGTM
No issues beyond the changeset omission covered in the Release section.
📋 Code Quality: ✅ LGTM
The FORGE_OPENAPI_VERSION pin in packages/cli/generate.ts matches the revision in the title. The new zero-trust organization edit command is registered in zero-trust/organization/index.ts, and its operation file, commands.json and schemas.json agree on the method, path and flags. The removal of page/per_page is consistent across the command files, the operation files and both metadata files.
⚡ Performance: ✅ LGTM
Generated code only; it adds no new requests, loops or I/O.
📝 Documentation: ✅ LGTM
No issues beyond the changeset omission covered in the Release section.
Reviewed commit: 3b2db032
Updates cf to
openapi@650bd71c22db3b938a4611bf4cc5afd896b400b7.650bd71c22db3b938a4611bf4cc5afd896b400b7This PR is maintained automatically by the Update OpenAPI workflow.