Repository navigation
Install Playwright Chromium without --with-deps in CI - #153
Merged
Merged
Conversation
The ubuntu-latest image already ships Google Chrome, so the system libraries Chromium needs are present. --with-deps only added fonts from Ubuntu's package mirror, which sometimes slows to tens of kB/s and has stretched CI runs from about a minute to 6-10 minutes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The CI job's
playwright install --with-depsstep installs about 25 MB of system packages (mostly fonts) from Ubuntu's package mirror. That mirror sometimes slows to 40–60 kB/s, which in cloudfour/cloudfour.com-patterns stretched one-minute runs to 6–11 minutes and once left a job hanging for six hours.The
ubuntu-latestrunner image already ships Google Chrome, so the libraries Chromium needs are already installed. This PR drops--with-depsso the step skips apt entirely, which is the same change as cloudfour/cloudfour.com-patterns#2607, where the browser tests passed with no missing-dependency warnings. The existing 10-minute cap stays as it is.Screenshots
Testing
apt-getoutput and no "Host system is missing dependencies" warning