Skip to content

feat(ui): uxdocs - add Interaction Guidelines page (#1916) - #2063

Merged
franzheidl merged 5 commits into
mainfrom
franz-uxdocs-interaction-guidelines-1916
Oct 7, 2026
Merged

feat(ui): uxdocs - add Interaction Guidelines page (#1916)#2063
franzheidl merged 5 commits into
mainfrom
franz-uxdocs-interaction-guidelines-1916

Conversation

@franzheidl

@franzheidl franzheidl commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

Adds a new Interaction Guidelines page to the UX docs (docs/ux/interaction-guidelines.md) and links it from the contents index and Application Design Guidelines.

Related Issues

Closes #1916.

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

@franzheidl
fix(ui): populate tabStyle in TabBarContext value for backwards compat
5f0ac1c 
Fixes #2056. The context provider only set `appearance`, leaving
`tabStyle` as `undefined` for any consumer reading it from
`TabBarContext`/`TabNavigationContext`. Both fields now carry the
resolved appearance value.

Signed-off-by: Franz Heidl <franz.heidl@sap.com>
@franzheidl
feat(ui): remove incorrect comment
33c2d7f 
Signed-off-by: Franz Heidl <franz.heidl@sap.com>
@franzheidl
feat(ui): uxdocs – add Interaction Guidelines page (#1916)
9b4a834 
Signed-off-by: Franz Heidl <franz.heidl@sap.com>
@changeset-bot

changeset-bot Bot commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: cc26201

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-07 15:50 UTC

@franzheidl
franzheidl requested a balanced review from Copilot October 7, 2026 13:42
Copilot AI reviewed Oct 7, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Two guidelines need accessibility corrections for screen-reader and keyboard users.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

Adds an Interaction Guidelines page to Juno’s UX documentation and integrates it into existing navigation.

Changes:

  • Documents interaction, feedback, consistency, disabled-state, and accessibility guidance.
  • Links the page from both UX indexes.
File Description
docs/​ux/​interaction-guidelines.md Adds the new guidelines page.
docs/​ux/​application-design-guidelines.md Links the new page.
docs/​ux/​0_contents.md Adds the page to the contents index.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/ux/interaction-guidelines.md Outdated
@franzheidl
feat(ui): uxdocs – mention ARIA announcements for feedback and disabl…
cc26201 
…ed states

Signed-off-by: Franz Heidl <franz.heidl@sap.com>
@franzheidl
franzheidl marked this pull request as ready for review October 7, 2026 13:51
@franzheidl
franzheidl requested a review from a team as a code owner October 7, 2026 13:51
@franzheidl
franzheidl merged commit fac0338 into main Oct 7, 2026
24 checks passed
@franzheidl
franzheidl deleted the franz-uxdocs-interaction-guidelines-1916 branch October 7, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@edda edda edda approved these changes
@MartinS-git MartinS-git MartinS-git approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Task](ui): ux docs – create Interaction Guidelines (overview) page

4 participants

@franzheidl @edda @MartinS-git