Repository navigation
fix(sandboxd): a required promoted claim is not sent to a warm peer at quota either - #265
Merged
Merged
Conversation
…to a warm peer at quota either #264 kept the warm redirect out of the missing-template branch; the quota branch after ClaimProvision still offered the warm candidates without require_promoted. A required claim at quota answers 429.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The branch #264 missed (CMGS): after
ClaimProvisionanswersErrQuota, the handler offered the warm candidates withoutrequire_promoted. The warm redirect now also skips a required claim, which keeps its 429. The regression test gains the quota rows; the required-at-quota row fails on the old handler with 200 and[warm:7777].