Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scene editor needs to use the same CLI scene services as its host without bundling another copy of the CLI implementation. This change publishes the shared browser runtime, supplies host-owned implementations through capabilities, and generates declaration-only inputs for the extension.
cocos-cli/scene-editor/hostand a browser host adapter with capabilities API 1, preserving the page SystemJS instance during service initialization.capabilitiesApiVersionso existing protocol 2 consumers retain their loader contract. Protocol 3 consumers require the corresponding scene editor extension and PinK loader updates.Validation:
npm run compilepassed, including browser runtime and declaration generation.Full PinK UI interaction and native simulator regression tests were not run.