V0.11.1/regression fix - #45
Open
gimlichael wants to merge 11 commits into
Open
gimlichael wants to merge 11 commits into
gimlichael wants to merge 11 commits into
Conversation
Introduces a patch release documenting strengthened git-remote-release capabilities: structured release-note opening format, curated release-highlight bullets, em dash prohibition, and deterministic verification. Enhanced Python collector validation gates check format compliance and reject malformed openings, missing bullets, unsupported punctuation patterns, and incomplete contributor attribution.
Reorganizes SKILL.md with a dedicated Non-Negotiable Rules section listing the structured opening contract, curated release-highlight bullets, and em dash prohibition. Enhances the Output Format section documenting the opening paragraph and bullet structure requirements. Adds a dedicated Em Dash Prohibition section clarifying the format constraint. Expands Data Collection Strategy with guidance on bundled collector, GitHub MCP tools, and gh CLI. Updates evals.json with enhanced expectations for the opening paragraph and bullet structure, and adds eval case #10 testing the rejection of bold-leading prose paragraphs and format violations.
Adds verify_summary() function to collect-release-evidence.py that enforces the structured release-note format contract: requires opening with 'This release ', rejects bold-leading prose paragraphs, validates release-highlight bullets with natural prose following bold lead-ins, enforces comma separation between non-final bullets and periods on final bullets, and prohibits em dashes. Expands test-release-evidence.py with comprehensive coverage including test_summary_structure_rejects_bold_paragraph_regression() for format regression detection and test_summary_structure_requires_bullets_and_natural_bold_leads() for bullet structure validation. Updates draft() helper to reflect required format structure.
Updates the git-remote-release skill description in the Available Skills table to emphasize the structured release-note format: opening summary line begins with 'This release ', followed by curated dash bullets with bold lead-ins and natural prose, with optional GitHub alert blocks and verified Sources entries. Updates the skill's feature list to highlight the release-story structure requiring the 'This release ...' opening and dash-bullet format, and strengthens the strict format constraint to clarify em dash prohibition in authored release-note prose. Clarifies that draft verification rejects malformed openings, missing highlight bullets, format violations, and incomplete contributor attribution.
|
Tighten validation rules to reject punctuation-only bullets, enforce em-dash prohibition in authored prose while preserving source titles, restrict GitHub alert blocks to supported markers only, and add comprehensive test coverage for these stricter requirements. Scope em-dash check to authored lines only, allowing exact source titles to preserve their original formatting.
Clarify release-note validation rules in README skill descriptions: em-dash prohibition applies to authored prose only, GitHub alert blocks must use only supported markers, and release-highlight bullets require explanatory prose after bold lead-ins. Align documentation with implementation improvements.
Update repository policy (AGENTS.md) and user-facing documentation (README.md) to clarify that same-request yolo/auto in git-remote-pr skips the approval wait but still shows the preview as status only.
Update skill instructions (SKILL.md) and corresponding eval cases (evals.json) to reflect clarified yolo/auto behavior: preview is shown as status only, no approval phrase is required or awaited.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request strengthens the git-remote-release skill with comprehensive release-note format validation. Introduces Python validation that enforces the structured opening contract, curated bullet format, and em dash prohibition. Adds regression tests and expands documentation to ensure consistent high-quality release notes.
Format validation:
Release documentation:
Skill specification:
Skill documentation:
Test coverage: