Repository navigation
Concepts: cross-contract interfaces and the two withdrawal paths #631
Description
Branch: Open your PR against dev. PRs targeting main are closed automatically.
Description:
Write contracts/docs/concepts-cross-contract-interfaces.md for token_interface.rs (in group_treasury and token_transfer), treasury_interface.rs, and the hand-written treasury_interface_client.rs in proposals. There are currently two ways to move treasury funds — group_treasury's own propose_withdraw / approve_withdraw / reject_withdraw multisig, and proposals::execute_withdraw calling into the treasury — and nothing explains how they relate.
Acceptance criteria:
- A diagram of every cross-contract call with the authorization each one requires
- States which withdrawal path is canonical, whether both are reachable in a deployment, and how the frontend chooses between them
- Documents ID type mismatches a caller must handle — proposal IDs are
u64inproposalsbutu32ingroup_treasury - Explains why
treasury_interface_client.rsis hand-written and how to keep it in sync whengroup_treasury's signature changes, and notes the unused_tokenparameter ongroup_treasury::initialize
Activity
Netty-kun commentedon Oct 19, 2026
@Netty-kun has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Netty-kun to this issue.
pre-cious-Igwealor commentedon Oct 20, 2026
@pre-cious-Igwealor has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @pre-cious-Igwealor to this issue.
G-ELM commentedon Oct 22, 2026
@G-ELM has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @G-ELM to this issue.
drips-wave commentedon Oct 22, 2026
Congratulations, @G-ELM! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.
🧑💻 @G-ELM: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
github-actions commentedon Oct 22, 2026
Closed by #684, merged into
dev.drips-wave commentedon Oct 22, 2026
This issue has been completed by @G-ELM as part of the Stellar Wave Program's 10th Wave 🥳
😎 @G-ELM: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.