Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A stored nil can be mistaken for a missing entry:
(get m :present :missing)returns:missingfor{:present nil}, and membership checks miss a nil hash-map key or hash-set member. Sorted-map membership andfindalso miss entries whose value is nil.Check the containing entry instead of relying on a non-NONE key/value cursor. This fixes
get,contains?, andfindin hash maps, sorted maps, and hash sets. The change retains the existing file format, public collection types, and xitdb-java dependency.Regression coverage exercises raw committed, transaction, frozen, and reopened views in memory and on disk. Both new tests failed before their corresponding fixes.
Validation:
clojure -M:test— 244 tests, 3,472 assertions, zero failures or errors.git diff --checkpasses.