Skip to content

Add use-modern-go agent skill from JetBrains/go-modern-guidelines - #60

Merged
ThomasK33 merged 2 commits into
mainfrom
add-use-modern-go-skill
Aug 29, 2026
Merged

Add use-modern-go agent skill from JetBrains/go-modern-guidelines#60
ThomasK33 merged 2 commits into
mainfrom
add-use-modern-go-skill

Conversation

@ThomasK33

Copy link
Copy Markdown
Member

Installs the JetBrains use-modern-go agent skill into .agents/skills/use-modern-go/, following the repo's existing skill-management convention.

What's in the diff

  • .agents/skills/use-modern-go/ — SKILL.md + scripts/run-tool.{sh,ps1} + scripts/VERSION (pins CLI v0.1.1), copied verbatim from upstream plugin/skills/use-modern-go/.
  • skills-lock.json — entry generated by the skills CLI (npx skills add JetBrains/go-modern-guidelines -s use-modern-go -y), same tool that produced the existing mattpocock/skills entries, so computedHash follows the CLI's own convention.
  • AGENTS.md — one-line "Modern Go" subsection pointing agents at the skill, matching the existing section style.

Verification (local)

$ sh .agents/skills/use-modern-go/scripts/run-tool.sh list
  • On first use the wrapper go installs github.com/JetBrains/go-modern-guidelines@v0.1.1 into ~/.cache/go-modern-guidelines/v0.1.1/ (repo pins go 1.26.3; install and run worked with the mise-managed go 1.26.5 toolchain).
  • list resolved the target Go version from go.mod and returned 48 guidelines applicable up to go 1.26 (newest first: new_expression, errors_as_type, sync_waitgroup_go, … down to time_since).
  • explain min_max (smoke test) returned the detailed guideline with before/after examples.
  • --version reports v0.1.1, matching scripts/VERSION.

Follow-up PR will run a guided modernization pass over the Go modules using this skill.


Generated with mux • Model: anthropic:claude-fable-5 • Thinking: xhigh

Installed via the skills CLI (npx skills add JetBrains/go-modern-guidelines
-s use-modern-go), which generated the skills-lock.json entry. Verified
locally: run-tool.sh list resolves go 1.26 from go.mod and returns the
guideline set; explain works.
@ThomasK33

Copy link
Copy Markdown
Member Author

@codex review

@ThomasK33

Copy link
Copy Markdown
Member Author

@codex security review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-29T12:42:41.245945Z f16d8b3 Manual request
🔒 Security Review Completed 2026-08-29T12:44:26.454278Z f16d8b3 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1ac9417817

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .agents/skills/use-modern-go/SKILL.md Outdated
@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 1ac9417817

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

A bare single-quoted path in PowerShell is a string literal, not a
command; prefix the call operator (&) so the documented invocation
actually runs the wrapper. One-line local deviation from upstream,
reported at JetBrains/go-modern-guidelines#25; drift disappears at the
next skills update once upstream merges the fix.
@ThomasK33

Copy link
Copy Markdown
Member Author

@codex review

@ThomasK33

Copy link
Copy Markdown
Member Author

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: f16d8b3c09

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: f16d8b3c09

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@ThomasK33
ThomasK33 merged commit 8209f33 into main Aug 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant