Repository navigation
🤖 fix: bump electron to 45.2.1 for Node2Shell (CVE-2026-111497) - #29
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kylecarbs
approved these changes
Nov 2, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
electronfrom^39.2.4(locked 39.2.4) to^45.2.1to patch CVE-2026-111497 (Node2Shell / HTTP2Shell), a Brotli decoder RCE.@electron/get2 -> 5,@types/node22 -> 24 for electron).src/electron/main.tsonly uses stable APIs (BrowserWindow,shell,Menu,dialog,nativeTheme), with sandbox/contextIsolation already on. I didn't find anything in the 40-45 breaking changes that touches it.Validation
bun run fmt:check,typecheck,lint,testpass (44/44).scripts/build-electron.ts+electron-builder --linux dirpackage withelectron=45.2.1; the packaged binary contains the patchedBROTLI_DECODER_ERROR_FORMAT_BLOCK_SWITCHdecoder marker.Follow-up: existing desktop installs stay vulnerable until a new
v*tag is cut sorelease.ymlpublishes fresh builds and electron-updater pulls them.