Skip to content

🤖 fix: bump electron to 45.2.1 for Node2Shell (CVE-2026-111497) - #29

Merged
kylecarbs merged 1 commit into
mainfrom
fix/bump-electron-node2shell
Nov 2, 2026
Merged

kylecarbs merged 1 commit into
mainfrom
fix/bump-electron-node2shell

Conversation

@coder

@coder coder Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Bumps electron from ^39.2.4 (locked 39.2.4) to ^45.2.1 to patch CVE-2026-111497 (Node2Shell / HTTP2Shell), a Brotli decoder RCE.

  • Electron builds Node against Chromium's Brotli, so the fix arrives via Chromium 148+ (Electron 42+). Every 39.x is still vulnerable, so a patch bump within 39 isn't enough.
  • Lockfile changes are limited to Electron's own dependency tree (@electron/get 2 -> 5, @types/node 22 -> 24 for electron).
  • src/electron/main.ts only uses stable APIs (BrowserWindow, shell, Menu, dialog, nativeTheme), with sandbox/contextIsolation already on. I didn't find anything in the 40-45 breaking changes that touches it.

Validation

  • bun run fmt:check, typecheck, lint, test pass (44/44).
  • scripts/build-electron.ts + electron-builder --linux dir package with electron=45.2.1; the packaged binary contains the patched BROTLI_DECODER_ERROR_FORMAT_BLOCK_SWITCH decoder marker.
  • Not smoke-tested with a GUI launch (headless workspace).

Follow-up: existing desktop installs stay vulnerable until a new v* tag is cut so release.yml publishes fresh builds and electron-updater pulls them.

@vercel

vercel Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
pulldash Ready Ready Preview Nov 2, 2026 4:26pm UTC

Request Review

@kylecarbs
kylecarbs merged commit 3dffc34 into main Nov 2, 2026
3 checks passed
@coder coder Bot mentioned this pull request Nov 2, 2026

This branch was successfully deployed

1 active deployment
Preview — b63d1daf Deployed Nov 2, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant