Conversation
anurag629
approved these changes
Oct 1, 2026
anurag629
left a comment
Member
There was a problem hiding this comment.
Hey @kudala-bharani, nice work again! This covers everything in #97, and I like that the error tests check the exact parse messages for both empty data and an empty schema. CI is green, merging this now.
If you want another one, just comment on any open hacktoberfest issue and I'll assign it to you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Adds 20 tests for the JSONPath and JSON Schema helpers. They cover empty and invalid inputs, the sample queries and their paths, no-match results, and validation errors for required properties, minimum values, and string lengths.
Branched from the latest
develop, including the Vitest 4 upgrade. Only the two test files changed.Closes #97
Type of change
Checklist
npm run lint && npm run test && npm run buildpasses locallylib/and have a test inlib/__tests__/— tests only; no logic changespage.tsx, client component,opengraph-image.tsx, and the bug report dropdown are all done — not applicableNotes for reviewers
Verified with Node 22.23.3 and Vitest 4.1.11: all 85 tests pass, lint exits successfully, and the production build passes. Lint still reports 13 warnings in unchanged files; the two new test files pass with zero warnings.