[vikramlc-cognite]

Summary

Scheduled and continuous tasks support Start/Stop Actions by default, and a task can opt out with actionable=False.

Type of change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that changes existing behavior)
• Refactor (no functional change)
• Documentation update
• Chore / tooling / CI

What changed

• tasks.py: added actionable: bool = True to ScheduledTask (including from_interval and from_cron) and ContinuousTask. StartupTask stays non-actionable.
• base.py: added _is_actionable() (a TypeGuard), which replaces every isinstance(t, ACTIONABLE_TASK_TYPES) check. An opted-out task gets no Start/Stop actions, is sent with action=False, and leaves its Start/Stop <name> names free for custom actions.

Why it changed

• Related issue: EDG-1013
• Actions should be on by default for every scheduled or continuous task, with a per-task way to turn them off.

What to focus on during review

• Check that every former ACTIONABLE_TASK_TYPES gate now goes through _is_actionable.

Test evidence

• 3 new tests in test_action_registration.py, covering the defaults, opt-out registration, and that an opted-out task doesn't reserve the action names.
• ruff and mypy pass. The unit tests pass; Locally integration tests were not tested as repo secrets in test_and_build.yml are unknown but integration tests pass in CI.

Risks and unknowns

• Existing extractors behave the same, because the default matches the old behavior.

Rollout and rollback

• No migration or config change. To roll back, revert the PR.

Checklist

• Self-reviewed the diff
• Tests added or updated
• Docs updated (docstrings and changelog)
• No secrets, credentials, or PII committed
• Breaking changes called out above (N/A)

[vikramlc-cognite]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces an 'actionable' flag to tasks, allowing them to opt out of auto-generated Start/Stop actions. It includes a new helper function '_is_actionable' to centralize this logic and updates various task management methods to use this helper. The review comment correctly identifies a compatibility issue: 'TypeGuard' should be imported from 'typing_extensions' rather than 'typing' to support Python versions earlier than 3.10.

[gemini-code-assist]

Code Review

This pull request introduces an actionable flag to tasks (defaulting to True for ScheduledTask and ContinuousTask), allowing individual tasks to opt out of auto-generated Start/Stop actions. It adds a helper function _is_actionable using TypeGuard to check if a task is actionable, and updates registration and dispatch logic accordingly. Tests are also added to verify this behavior. Feedback is provided regarding the import of TypeGuard from typing, which will cause a runtime error on Python 3.9; it should be imported from typing_extensions instead to maintain backward compatibility.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.20%. Comparing base (d3fdb50) to head (4ecfa94).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #586      +/-   ##
==========================================
+ Coverage   84.09%   84.20%   +0.10%     
==========================================
  Files          46       46              
  Lines        4710     4711       +1     
==========================================
+ Hits         3961     3967       +6     
+ Misses        749      744       -5     

Files with missing lines	Coverage Δ
cognite/extractorutils/unstable/core/base.py	86.94% <100.00%> (ø)
cognite/extractorutils/unstable/core/tasks.py	100.00% <100.00%> (+2.50%)	⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[vikramlc-cognite]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces an actionable flag for scheduled and continuous tasks, allowing individual tasks to opt out of auto-generated Start/Stop actions. It refactors the codebase to use a new _is_actionable helper function and adds corresponding unit tests. Feedback on the changes suggests importing TypeGuard from typing_extensions instead of typing to prevent runtime ImportError crashes on Python versions prior to 3.10.

[HMEiding]

The description says "the 48 errors are integration tests that need CDF credentials set". I don't see CI failing, but if tests are disabled due credentials missing, it should be fixed.

[vikramlc-cognite]

The description says "the 48 errors are integration tests that need CDF credentials set". I don't see CI failing, but if tests are disabled due credentials missing, it should be fixed.

Nothing is disabled, those errors were only from my local run without CDF credentials. CI sets them from repo secrets in test_and_build.yml and runs the full tests suite (no skip markers), and it's green. Fixed the wording in the description.

[HMEiding]

I see dropping the guard meant widening task: ScheduledTask | ContinuousTask to task: Task which now also admits StartupTask. Just noting there is a tradeoff here. Are you fine with the widening?

Separately, the docstring says "for an actionable task run", but opted-out scheduled tasks also run through here, so perhaps update the text?

[vikramlc-cognite]

Good catch. These are remnants of the local testing I had done. Reverted the widening and also updated the docstring to cover opted-out tasks.

[HMEiding]

Noticed a test gap, but otherwise LGTM.

[HMEiding]

I noticed a test gap: There is no test asserting that a dispatched action on a non-actionable task fails.

[vikramlc-cognite]

Added test_dispatch_action_on_opted_out_task_reports_failed in test_action_dispatch.py. It covers Start/Stop on both an opted-out scheduled task and an opted-out continuous task, and asserts a single failed update, that the target never ran, and that no running-task token was registered.

[HMEiding]

🦄

[HMEiding]

🦄