Repository navigation
feat(unstable): Raise the available actions limit to cover two actions per task - #594
Closed
vikramlc-cognite wants to merge 2 commits into
Closed
vikramlc-cognite wants to merge 2 commits into
vikramlc-cognite wants to merge 2 commits into
Conversation
…s per task Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request increases the maximum number of available actions sent at startup from 100 to 250 in the unstable package. This is achieved by introducing a new MAX_AVAILABLE_ACTIONS constant in _dto.py and updating the validation limits and test cases accordingly. I have no feedback to provide as the implementation is clean and well-tested.
Contributor
Author
|
Superseded by #596, which targets master directly (no dependency on the stacked PRs). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raises the client-side
availableActionslimit in the startup request from 100 to 250, matching Odin, so an extractor with up to 100 actionable tasks (a start and a stop action each) plus custom actions can register.Type of change
What changed
unstable/core/_dto.py: newMAX_AVAILABLE_ACTIONS = 250, used byAvailableActionList(was a hard-coded 100).tests/test_unstable/test_dto.py: available-actions max-length test uses the constant; the action-updates test stays at 100.tests/test_unstable/test_action_registration.py: 100 tasks (200+ actions) build a validStartupRequest;MAX_AVAILABLE_ACTIONStasks overflow and are rejected.CHANGELOG.md: Unreleased entry.Why it changed
Each actionable task costs 2 actions, so the old cap of 100 allowed only 49 actionable tasks while Odin's
task_limitis 100. A 50th task made the startup request invalid.What to focus on during review
MAX_AVAILABLE_ACTIONS; it is a duplicated constant, not shared.MAX_ACTION_UPDATES_PER_CHECKIN(100) is intentionally unchanged: excess updates carry over to the next check-in.Test evidence
uv run pytest tests/test_unstable/test_dto.py tests/test_unstable/test_action_registration.py-> 71 passedpre-commit run --all-files-> all hooks passedtests/test_unstablesuite has the same live-CDF failures/errors as cleanmaster(noCOGNITE_DEV_PROJECTlocally); needs CI.Risks and unknowns
Rollout and rollback
Checklist
🤖 Generated with Claude Code