Repository navigation
Stop reporting a closed console as a user abort, and shield the host's own work - #172
Merged
Merged
Conversation
…s own work The telemetry service decides what a user abort is by searching the log text for sigint, ctrl+c, sighup and a few phrases. Our hangup message said SIGHUP, so every run that lost its console was filed as "the operator pressed Ctrl-C": of 300 aborted records in the thirteen hours after the fix shipped, 81 were this message. Twenty of those were real failures -- apt errors, containers that would not start -- which left the failure rate understated and the bugs invisible. The message now says the terminal closed, and a test keeps every hangup message clear of the words the classifier reads. The shield that kept apt and npm alive only covered commands run through silent(). pct create and the four pveam download calls run bare on the host, so a console closed during the template download still killed the run with 129. They go through the same helper now, which is named for what it does rather than for silent().
Contributor
Try this branchThe engine and the scripts resolve independently, so a production script can COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/hangup-followups \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"Swap This PR touches both backends. Worth running on a Proxmox VE and an Incus host. Run a script from a fork as wellcurl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/hangup-followups/tools/run.sh |
bash -s -- https://raw.githubusercontent.com/YOU/DevScripts/your-branch ct/debian.sh \
https://raw.githubusercontent.com/community-scripts/core/fix/hangup-followupsNote that Useful flags while testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
The telemetry service decides what a user abort is by searching the log text for sigint, ctrl+c, sighup and a few phrases. Our hangup message said SIGHUP, so every run that lost its console was filed as "the operator pressed Ctrl-C": of 300 aborted records in the thirteen hours after the fix shipped, 81 were this message. Twenty of those were real failures -- apt errors, containers that would not start -- which left the failure rate understated and the bugs invisible. The message now says the terminal closed, and a test keeps every hangup message clear of the words the classifier reads.
The shield that kept apt and npm alive only covered commands run through silent(). pct create and the four pveam download calls run bare on the host, so a console closed during the template download still killed the run with 129. They go through the same helper now, which is named for what it does rather than for silent().
🔗 Related Issue
Fixes #
✅ Prerequisites (X in brackets)
API.txtwas updated to match.🤖 AI Assistance (X in brackets)
🛠️ Type of Change (X in brackets)
README,docs/,CONTRIBUTING.md, or other docs.