Skip to content

Fix setWorkflowTags to send PUT #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ling-senpeng13 merged 1 commit into from
Oct 8, 2026
Merged

Fix setWorkflowTags to send PUT #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conductor-client/src/main/java/io/orkes/conductor/client/http/TagsResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ public void setTaskTags(List<TagObject> tagObjects, String taskName) {

public void setWorkflowTags(List<TagObject> tagObjects, String workflow) {
ConductorClientRequest request = ConductorClientRequest.builder()
.method(Method.GET)
.method(Method.PUT)
.path("/metadata/workflow/{workflow}/tags")
.addPathParam("workflow", workflow)
.body(tagObjects)
Expand Down
6 changes: 4 additions & 2 deletions tests/src/test/java/io/orkes/conductor/client/http/MetadataClientTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,11 @@ void tagWorkflow() {
}
}
metadataClient.addWorkflowTag(tagObject, Commons.WORKFLOW_NAME);
metadataClient.setWorkflowTags(List.of(tagObject), Commons.WORKFLOW_NAME);
// A different tag, so the assertion fails unless setWorkflowTags replaces the existing one.
TagObject replacement = new TagObject().key(tagObject.getKey()).value(tagObject.getValue() + "-replaced");
metadataClient.setWorkflowTags(List.of(replacement), Commons.WORKFLOW_NAME);
List<TagObject> tags = metadataClient.getWorkflowTags(Commons.WORKFLOW_NAME);
Assertions.assertIterableEquals(List.of(tagObject), tags);
Assertions.assertIterableEquals(List.of(replacement), tags);
}

// ==================== Additional CRUD Tests ====================
Expand Down
Loading