fix(#3533): replace stale quick-build-args.conf with empty string - #3534
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#3533): replace stale quick-build-args.conf with empty string#3534fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
The awk gsub on line 64 of release-branch-pipeline-patch.sh
replaced main-pre-merge-build-args.conf with
quick-build-args.conf, a file that does not exist in the
repository. This caused the generated pull-request pipeline
YAML to reference a non-existent build-args-file, requiring
manual correction on every release branch PR.
Change the replacement to empty string ("") to match the
pattern already used on line 65 for main-build-args.conf,
and to match what PR authors have been manually correcting
to on the v0.8 and v0.9 release branches.
Note: pre-commit could not run (network restriction
prevented fetching the conforma/hooks repo). The only
configured hook (check-commit-message) applies to commit
messages, not file content.
Closes #3533
|
🤖 Finished Review · ✅ Success · Started 7:18 PM UTC · Completed 7:30 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.95 |
|
Risk Assessment: low (1/5) DetailsMinimal single-line bug fix in a rarely-touched hack script, replacing a stale file reference with an empty string; scope perfectly matches the linked issue with no security, dependency, or CI impact. |
|
Looks good to me |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Replace the stale
quick-build-args.confreference inhack/release-branch-pipeline-patch.shwith an empty string (""), matching the pattern already used formain-build-args.confon the next line.Why:
The awk gsub that transforms
main-pre-merge-build-args.confwas replacing it withquick-build-args.conf, a file that does not exist in the repository. This caused every release branch setup PR to produce incorrect pipeline YAML that required manual correction. Both human reviewer (simonbaird) and the review agent independently flagged this on PR #3529.Tickets:
Closes #3533
Post-script verification
agent/3533-fix-build-args-conf)af3fe00e4120446b6a808687cc3a5af96ce3d779..HEAD)