Repository navigation
Pin signer hotfix to ignore unrelated webhook completions - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful finalizer completions currently return
403 workflow not eligible, incrementingwebhook_dispatchfailures and raising alerts despite successful signing. Signer commita51fe2fa137457fa786236089872e6343e16dcdbreturns HTTP 200 with{"ignored":true}for authenticated completions from unrelated workflows in configured repositories. Authentication, repository identity, and eligible signing-request validation remain enforced.Only
signer_revisionchanges. Version 3, policy revision 7, policy hash, certificates, key identities, full Play lineage, API 33 rotation and allowed workflows remain unchanged. Native policy export confirms the public fields; the existing deployment hash is retained exactly. Pending dynamic TUF work is excluded.Validation:
1dbe168cce00291c3a94ef8a699c3c3f33fed996356169bddbb439b81a46c787.The tested image is staged in a private pending directory on the signer host. Activation waits for this reviewed source pin to reach main, then rechecks the active image/configuration and empty queue before restarting the VM. No signing configuration, keys or collector deployment changes are required.