chore(errors): drop the dead STORAGE_* file-processing lifecycle codes - #1850
Conversation
Re-audited constructive-db main (post #3834): the seven SQL-side lifecycle codes are raised nowhere, and the two runtime-only companions have no caller in any repo. Regenerated the inventory/registry and removed the curated entries plus the test that pinned them.
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Review complete. No issues found — approved ✅. The change prunes 9 no-longer-raised
All Reviewed commit: 78caa07 |
Summary
Follow-up to #1849, which re-audited constructive-db and noticed seven
STORAGE_*file-processing lifecycle codes (STORAGE_ACCESS_CLAIM_MISMATCH,STORAGE_FILE_NOT_FOUND,STORAGE_SOURCE_HASH_REQUIRED,STORAGE_SOURCE_HASH_MISMATCH,STORAGE_INVALID_COMPLETION_RESULT,STORAGE_PROCESSING_CONFLICT,STORAGE_INVALID_UPLOAD_DOCUMENT) that constructive-db no longer raises anywhere, but kept them in the inventory only becausestorage-lifecycle.test.tspinned them.This PR makes the registry match reality:
scripts/db-error-inventory.json/src/generated/registry.generated.ts— freshaudit-db-errors.py+generate-registry.pyrun against constructive-dbmain(post constructive-db#3834). The diff to the inventory is exactly those seven removals; no other code changed.src/registry.ts— removed the curated overrides for those seven, plus the two "runtime-only" companionsSTORAGE_BUCKET_DATABASE_MISMATCH/STORAGE_FILE_TARGET_UNAVAILABLEand theStorageFileContexttype. Neither runtime code has a caller in constructive, constructive-db, constructive-hub, dashboard or any other checked-out repo; they existed only to accompany the lifecycle set.__tests__/storage-lifecycle.test.ts— deleted; it only exercised the nine removed codes.STORAGE_BUCKET_NOT_RECONCILEDand every otherSTORAGE_*code that constructive-db actually raises are untouched.Verified:
pnpm lint,tsc --noEmit, andpnpm test(41 tests) inpackages/errors.Link to Devin session: https://app.devin.ai/sessions/030828a4ea704932a6eb20f098dcd129
Open in Devin Desktop: https://app.devin.ai/desktop/session/030828a4ea704932a6eb20f098dcd129?variant=devin
Requested by: @pyramation