Make debug() compile-time- and runtime-configurable, and use it around mount_setattr() - #796
Merged
Merged
Conversation
smcv
changed the title
Collaborator
Author
Now that bubblewrap doesn't support being setuid, we can safely look at environment variables to decide whether to emit noisy debug messages. Instead of inventing our own environment variable, let's use `DEBUG_INVOCATION` as popularized by systemd. Enable debug messages in one CI pass, leaving them disabled in the other. Signed-off-by: Simon McVittie <smcv@collabora.com>
Signed-off-by: Simon McVittie <smcv@collabora.com>
Collaborator
Author
|
360dcd8: rebased, no functional change. |
cgwalters
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slightly modernize CI #795 (based on that PR to avoid merge conflicts)
Add a mechanism to enable debug() at compile-time
Now that bubblewrap doesn't support being setuid, we can safely look
at environment variables to decide whether to emit noisy debug messages.
Instead of inventing our own environment variable, let's use
DEBUG_INVOCATIONas popularized by systemd.Enable debug messages in one CI pass, leaving them disabled in the
other.
bind-mount: Add some debug() calls around mount_setattr()