Repository navigation
test(content-type-sidebar): getData and onSave from the spec - #195
pritesh-jain-cstk wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
🔒 Security Scan Results
⏱️ SLA Breach Summary
🟠 High Severity - SLA Breached Issues (with fixes)Showing 6 issue(s) that have exceeded the 30-day SLA threshold:
🟡 Medium Severity - SLA Breached Issues (with fixes)Showing 10 issue(s) that have exceeded the 90-day SLA threshold:
ℹ️ Vulnerabilities Without Available Fixes (Informational Only)The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:
❌ BUILD FAILED - Security checks failed Please review and fix the security vulnerabilities before merging. |
Branch graph
Epic MKT-21672. This PR is highlighted. Only [Routine] depends on [Tests]; the rest are independent.
What
Jira: MKT-22130
Consumer impact: none. Built
mainand this branch and diffeddist/src/**/*.d.ts: no diff. Tests only.__test__/contentTypeSidebarWidget.test.ts(3 tests).ContentTypeSidebarWidgetwas the least-covered public location (25% lines, now 95%). Spec: product-wikideveloper-hub/04-platform-contracts/app-sdk-reference.md(currentContentType,getData,onSave) and the published JSDoc (getData "Get the current content type data"; onSave runs "every time a content type is saved"). The public location page does not describe the methods.event.datato the callback, and returning an empty object fromgetDataeach fail at least one test.api()4xx/5xx handling (MKT-19619) is tested by fix: MKT-19619 appSdk.api() drops body/status text/headers on 4xx/5xx #190 (__test__/adapter.test.ts); not repeated here. Note fix: MKT-19619 appSdk.api() drops body/status text/headers on 4xx/5xx #190 targetsdevelop, which is 24 commits behindmain.collectCoverageFromalready covers all ofsrc). No threshold added.Readiness items
tests.from-spec(partly),tests.coverage(partly)Commands (exit codes, Node 24 locally)
npm cinpm run lintnpm run buildnpx tsc --noEmit -p .npm testnpm audit --omit=devCI:
security-scafails here as onmain: the lock pins axios 1.16.0 (8 High). That is fixed by #191 (MKT-22129 links it), not by this PR. The pre-push hook (npm test) passed on every push; none bypassed. Local Snyk cannot authenticate (SNYK-0005); the PR's Snyk checks are the scan.🤖 Generated with Claude Code