Repository navigation
Fix: cleartext HTTP in test and axios/follow-redirects vulnerabilities (Snyk) - v1.5.5 - #157
Conversation
chore: back-merge main into development
chore: back-merge main into development
chore: back-merge main into development
Brings back-merge branch up to date with development so main can be back-merged cleanly (DX-20927). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DX-20927 | Back-merge main into development
Publish on release:published from release.yml so the npm trusted publisher can be keyed on the filename, drop NODE_AUTH_TOKEN in favour of id-token: write (OIDC), run on Node 24 with npm@latest (trusted publishing needs npm >= 11.5.1), check out the release tag without persisted credentials. GitHub pre-releases go to the beta dist-tag. The GitHub Packages job gains the packages: write permission it was missing and keeps publishing with the job's own token. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Refuse to publish when the release tag is not "v" + the package.json version, so a tag cut on the wrong commit cannot publish an older version under a newer tag. The GitHub Packages job now uses the same beta/latest dist-tag rule as the npm job, so a GitHub pre-release never becomes latest on either registry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Snyk (snyk test --all-projects): 13 issues (8 high, 5 medium, all axios 1.18.1) -> 0. Regenerated package-lock.json (axios 1.18.1 -> 1.20.0). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…velopment chore: back-merge main into development
Lock file regenerated (fixed 3 on its own: body-parser high, markdown-it high, fast-uri moderate; all dev-only). Direct upgrades: none (no patch or minor bump clears a finding) Overrides: none (remaining transitive fixes are cross-major) Vuln count: snyk 0 → 0, npm audit 13 → 10. Build verified passing. .talismanrc: package-lock.json checksum replaced by a filecontent/base64content ignore so lock regens stop tripping talisman. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The check-version-bump workflow requires package.json to be above the latest tag once a PR changes it; this PR's Snyk lock fix does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Coverage report step posts a PR comment, which the default read-only
GITHUB_TOKEN refuses ("Resource not accessible by integration"), so Build &
Test failed although every test passed. Grant pull-requests: write on the job
and keep contents: read for the checkout.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Throwaway self-signed https test server; axios ^1.20.0, follow-redirects 1.16.2; v1.5.5. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
chore(release): publish to npm with trusted publishing
The job posts a coverage comment on the PR and the step fails with "Resource not accessible by integration" because the token is read-only. Declare the permissions the job needs, as the js-core and typescript coverage workflows already do. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
|
Coverage report for commit: 42cb6ee Summary - Lines: 85.93% | Methods: 96.08% | Branches: 67.22%
🤖 comment via lucassabreu/comment-coverage-clover |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Lock file regenerated (fixed 13 snyk and 7 npm audit findings on its own). Direct upgrades: axios ^1.17.0 -> ^1.20.0, mocha ^11.7.1 -> ^11.8.0, mochawesome ^7.1.3 -> ^7.1.4 Overrides: none Vuln count: snyk 13 -> 0, npm audit 53 -> 46. Build verified passing. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ngelog The previous commit brings in the dependency refresh from #153 (package-lock.json, mocha, mochawesome) alongside the axios and follow-redirects fixes already in this PR. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
…package-lock.json - merge the 1.5.5 release changes from development (trusted-publishing release workflow, release.yml, .talismanrc, changelog, version 1.5.5) - resolve .github/workflows/unit-test.yml (same pull-requests: write permission on both sides) and CHANGELOG.md (single v1.5.5 entry combining both) - delete package-lock.json and node_modules, then clean npm install to regenerate the lock file - npm ci --dry-run passes; unit tests and build pass; snyk test reports 0 vulnerabilities Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
Combine the two `fs` imports into one so `npm run lint` passes (import/no-duplicates). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
Summary
Resolves DX-9929 (cleartext HTTP in a localhost test) plus the unticketed
axios/follow-redirectsvulnerabilities (v1.5.5).test/unit/concurrency-Queue-test.jsnow serves over https using a throwaway self-signed certificate generated per run withopenssl(no new dependency), trusted only while that file's tests run.axiosfloor ^1.17.0 → ^1.20.0 andfollow-redirects→ 1.16.2 (same major / patch level). Version 1.5.4 → 1.5.5 with a changelog entry.Verification
snyk test: 15 → 0.snyk code test: the ticketed cleartext finding is cleared. 3 SSRF findings remain inlib/core/concurrency-queue.js; they are false positives (a retry re-sends the caller's original request, and the header only sets the wait time) and are not part of this change.🤖 Generated with Claude Code