Repository navigation
Fix: replace hardcoded test credentials; harden report XML parsing (Snyk) - #54
Merged
Merged
Conversation
Back merge
Brings back-merge branch up to date with development so master can be back-merged cleanly (DX-20927). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The repo root has no project or solution file, so Snyk could not detect target files. Restore both projects first and scan with --all-projects. Refs DX-20927 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With --all-projects the Snyk dotnet action did not produce snyk.json, so the sca-policy step failed even though the scan passed. Refs DX-20927 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Addresses Copilot review: only the sca-policy step needs pull-requests: write, so the Snyk scan now runs in a read-only job and hands snyk.json to a dependent security-sca job. All action refs are pinned to commit SHAs. The policy job keeps the security-sca name used by the required check. Refs DX-20927 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DX-20927 | Back-merge master into development
Replace hardcoded API keys and client secrets in tests with per-run generated values and remove deepcode ignore comments. Use defusedxml (optional, stdlib fallback) in the test report script. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
cs-raj
approved these changes
Nov 2, 2026
cs-raj
approved these changes
Nov 2, 2026
Aravind-Kumar-cstk
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the Snyk Code findings in this repo (DX-22794 to DX-22821 except the one for
ContentstackClient.SetHeader, see below).TestSecretshelper (per-run generated API key / client secret) and replaced the hardcoded"test_api_key","test_client_secret"and"a-real-secret"literals everywhere, including the asserts, so they stay consistent. Removed thedeepcode ignoresuppression comments from the tests.Scripts/generate_test_report.py: usesdefusedxmlwhen installed (Scripts/requirements.txt), falling back to the stdlib parser, so behaviour is unchanged without it. Clears the insecure-XML-parser findings.Not fixed (intentionally)
SetHeader(string key, string value)finding: Snyk flags the parameter names on the public signature; the only fix is renaming them, which would break named-argument callers.Verification
snyk code test: 28 → 1 (theSetHeadersignature above);snyk test: 0 vulnerabilities.🤖 Generated with Claude Code