Repository navigation
fix(starter-pack): model fixes for migrated SAP SmartEdit content (DX-31800) - #35
Open
pritesh-jain-cstk wants to merge 3 commits into
Open
pritesh-jain-cstk wants to merge 3 commits into
pritesh-jain-cstk wants to merge 3 commits into
Conversation
…t hold (DX-31800) A SmartEdit migration of SAP's electronics homepage, checked slot by slot against SAP with occFallback off, found three model gaps: - landing_page and content_page had no bottom_header_slot (SAP puts the page title there); landing_page had no HomepageNavLink slot. Both fields added; homepage_nav_link added to SLOT_FIELD_TO_SAP_NAME. - global_slots.footer only took navigation and links, so authoring the footer dropped SAP's copyright paragraph and consent flex blocks. It now also accepts cms_paragraph_component and cms_flex_component. Functional shell components (search box, mini cart, site context) stay on OCC as before: that is the hybrid design, not a gap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ort files (DX-31800) - landing_page carries ContentPage1Template's body_content and side_content; the content_page type is removed. The page adapter resolves every per-route page against the single cmsPageContentType, so content_page was never read. - Every content type gets sap_uid and sap_catalog_version (not localized) so a re-run of the SAP SmartEdit migration updates the entries it created. - The pack ships export-info.json (contentVersion 2) and content_types/schema.json; without them csdx 1.63+ imports 0 entries. - README example uses landing_page, like ng add. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
🔒 Security Scan Results
⏱️ SLA Breach Summary
ℹ️ Vulnerabilities Without Available Fixes (Informational Only)The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:
✅ BUILD PASSED - All security checks passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Starter-pack model fixes so SAP SmartEdit content migrated into Contentstack lands in a model the connector actually reads (Jira DX-31800, epic DX-30753).
landing_page.bottom_header_slot,landing_page.homepage_nav_link(+HomepageNavLinkin the slot map), andglobal_slots.footeraccepts paragraph and flex blocks (SAP's copyright and consent blocks).landing_pagenow also carries ContentPage1Template'sbody_contentandside_content; thecontent_pagetype is removed. The page adapter resolves every per-route page against the singlecmsPageContentType(resolvePageQuery;pageTypeMappingonly serves shared product/category layouts), socontent_pagecould never be read.ng addalready setscmsPageContentType: 'landing_page'; the README example now does too. The code default (cms_page) is unchanged so hand-wired installs are not affected.sap_uidandsap_catalog_version(text, not localized). The SAP SmartEdit migration fills them so a re-run updates the entries it created instead of importing duplicates (a secondcsdximport duplicates entries). Empty on content authored in Contentstack.export-info.json(contentVersion: 2) andcontent_types/schema.json. Without them csdx 1.63+ reads the folder as the v1 layout and imports 0 entries; the pack's entries are already in the v2 layout.Generated from
generate-content-types.mjsas before;content-types.spec.tschecks every change and that the shipped files equal the generator output.Not added, on purpose: a type for
CMSImageComponentand a field forTopHeaderSlot. Spartacus 2211 has no CMS mapping for the first and noTopHeaderSlotin its layout, so neither renders on a Spartacus storefront (SAP's ownTopHeaderSlotis empty on electronics-spa).Testing
npm test), schematics 8/8,npm run typecheckclean,npm run lint0 errors (54 existing warnings).csdximport + publish: 117/117 entries, 12/12 images. Reconciliation against SAP with the connector's normalizer: 5 pages, 85/85 checks, 0 CRITICAL. Evidence: contentstack/apps-workspace PR chore: update package-lock.json with dependency version upgrades #9,local-skills/sapcc/sapcc-smartedit-e2e/records/evidence/model-fix-20261103/.Upgrade note
Stacks that imported an older starter pack keep their
content_pagetype; it was never queried, so nothing they render changes. Add the new fields by re-importing the content types or editing them in the stack.🤖 Generated with Claude Code
Re-verified 2026-11-05
Re-run on this PR's head by an independent verification pass (spot-checked by re-running). Only what was run is listed as verified.
Ran on head
af55fec:lint(0 errors, 54 existing warnings),format:check,typecheck,test:all(Jest 191/191, schematics 8/8) andbuild, all exit 0.content-types.spec.tschecks the shipped content types equal the generator output. (npm cineeds the SAP registry token; an identical-lock install was reused.)Recorded, not re-run: the 2026-11-03 run (117/117 entries, 12/12 images, reconciliation 5 pages 85/85, 0 CRITICAL; evidence in apps-workspace #9).
Not verified: csdx import with and without
export-info.jsonandschema.json; storefront render after this change.