Skip to content

fix(deps): bump axios to 1.20.0 and express to 4.22.3 - #32

Merged
contentstackMridul merged 1 commit into
mainfrom
fix/snyk-sla-2026-10-29
Oct 29, 2026
Merged

contentstackMridul merged 1 commit into
mainfrom
fix/snyk-sla-2026-10-29

Conversation

@contentstackMridul

Copy link
Copy Markdown
Contributor

Summary

Clears the open Snyk findings on package.json except one adm-zip advisory that has no fixed release yet.

  • axios ^1.18.0 → ^1.20.0 (locked at 1.20.0). 1.20.0 is the first release that fixes the current batch of axios advisories: SSRF through the fetch adapter's redirect handling, ReDoS in the data-URI and NO_PROXY parsers, several prototype-pollution gadgets, and unbounded allocation.
  • express 4.22.2 → 4.22.3. This patch widens express's qs range to ~6.16.0. With that, the lockfile can move to patched qs 6.16.2, body-parser 1.20.9, proxy-addr 2.0.8 (the IPv4-mapped IPv6 trust-subnet spoofing fix) and follow-redirects 1.16.2. No overrides needed.

The only axios call is the GitHub zipball download in src/Github/index.ts. It's a streamed GET through the Node HTTP adapter. The 1.20 breaking changes cover status-code aliases, interceptor handling, fetch-adapter redirects and HTTP/2 proxying, and none of them touch that path. I picked 1.20.0 over 1.21.0 because 1.21 changes more runtime behaviour than these fixes need.

Still open

adm-zip 0.6.1 is still flagged for an interpretation-conflict issue that Snyk lists with no fixed version. It needs an upstream release or an ignore.

Testing

  • npm test: 8 suites, 247 tests pass (same as main)
  • npm run build passes
  • npm run lint is clean
  • snyk test: 1 critical, 12 high and 10 medium on main, down to the 1 adm-zip medium

Release

There's no version bump here. Consumers get the new axios floor only after a release, so bump and cut a release after merge if you want that to reach them.


🤖 Generated with Claude Code

axios 1.20.0 is the first release that clears the current axios
advisories (SSRF, ReDoS, prototype pollution, unbounded allocation).
The only call site is the GitHub zipball download in src/Github, which
uses the Node HTTP adapter with a streamed GET, so none of the 1.20
behaviour changes apply.

express 4.22.3 widens its qs range to ~6.16.0, which lets the lockfile
reach patched qs (6.16.2), body-parser (1.20.9), proxy-addr (2.0.8) and
follow-redirects (1.16.2) without any overrides.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@contentstackMridul
contentstackMridul requested a review from a team as a code owner October 29, 2026 05:51
@snyk-io

snyk-io Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 0 25 ✅ Passed
🟡 Medium Severity 0 1 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

ℹ️ Vulnerabilities Without Available Fixes (Informational Only)

The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:

  • Critical without fixes: 0
  • High without fixes: 0
  • Medium without fixes: 1
  • Low without fixes: 0

✅ BUILD PASSED - All security checks passed

@kirtesh-cstk kirtesh-cstk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@contentstackMridul
contentstackMridul merged commit 888a5b1 into main Oct 29, 2026
7 checks passed
@contentstackMridul
contentstackMridul deleted the fix/snyk-sla-2026-10-29 branch October 29, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants