Skip to content

chore(renovate): drop automerge - #333

Merged
robelest merged 1 commit into
mainfrom
chore/renovate-no-automerge
Aug 26, 2026
Merged

robelest merged 1 commit into
mainfrom
chore/renovate-no-automerge

Conversation

@robelest

Copy link
Copy Markdown
Collaborator

The config asked for automerge on routine and devDependency updates, but the repository has auto-merge disabled, so nothing ever merged itself. The five CI action bumps merged today had been sitting green since April for exactly this reason.

We don't want dependency PRs merging without review, so this removes the intent rather than leaving a config that silently changes behaviour the moment someone flips the repository setting.

The major and devDependencies rules existed only to modulate automerge and go with it. Renovate defaults to no automerge.

Worth noting what the old ordering did: packageRules apply in order and later matches win, so devDependencies: automerge true overrode major: automerge false. Major devDependency bumps like #331 (@convex-dev/eslint-plugin v3 to v4) and #249 (@vitejs/plugin-react v4 to v6) were configured to merge without review. The disabled repository setting was the only thing stopping them.

Grouping is unchanged, so routine updates still batch into one PR.

The config asked for automerge on routine and devDependency updates, but
the repository has auto-merge disabled, so nothing ever merged itself.
The intent sat dormant behind a setting rather than being expressed.

We don't want dependency PRs merging without review, so remove it rather
than leave a config that changes behaviour the moment someone flips the
repository setting. The `major` and `devDependencies` rules existed only
to modulate automerge and are dropped with it; Renovate defaults to no
automerge.

Grouping is unchanged, so routine updates still batch into one PR.

Claude-Session: https://claude.ai/code/session_01Y2txpSBZpQFEkifkDYSwvG
@pkg-pr-new

pkg-pr-new Bot commented Aug 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@convex-dev/agent@333

commit: 63f9347

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: get-convex/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e1d9c1bd-ba4c-4a0f-be96-32df19623437

📥 Commits

Reviewing files that changed from the base of the PR and between 1c0474d and 63f9347.

📒 Files selected for processing (1)
  • renovate.json

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The Routine updates rule in renovate.json no longer sets automerge: true. Minor, patch, pin, and digest updates now require manual merging. Major update and devDependencies rules remain unchanged.

Merge Risk: ⚪ Minimal · up to 63f93

This localized configuration change removes unintended dependency auto-merge behavior while leaving update grouping unchanged; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Renovate automerge configuration change and matches the primary objective of the pull request.
Description check ✅ Passed The description accurately explains the removal of Renovate automerge configuration, the effect on dependency review, and the unchanged grouping behavior.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/renovate-no-automerge

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@robelest
robelest merged commit c9eb44c into main Aug 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant