Repository navigation
Clarify snapshot consistency and revalidate example batches - #22
Open
ianmacartney wants to merge 3 commits into
Open
ianmacartney wants to merge 3 commits into
ianmacartney wants to merge 3 commits into
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
commit: |
There was a problem hiding this comment.
2 issues found across 16 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="benchmark.mjs">
<violation number="1" location="benchmark.mjs:125">
P2: When a batch-size or padding list contains a duplicate, this line reuses the same `caseId`, so the later per-case check sees twice the expected trials and aborts. Include a unique case index in `caseId` or reject duplicate inputs.</violation>
<violation number="2" location="benchmark.mjs:236">
P2: When the final log chunks are still buffered, this asynchronous kill is followed immediately by writing `logs.jsonl`, truncating the promised raw evidence. Wait for the stream to flush and close before writing the file.</violation>
</file>
ianmacartney
force-pushed
the
ian/find-snapshot-guarantees
branch
from
September 18, 2026 06:38
066836b to
9bef49a
Compare
Member
Author
|
FYI @mikecann I may not clean this up and land it until I get back, but some of what I said in our interview is true today but may not be true in the future |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Work queries may read an older database snapshot than their worker mutations, while each round sees the committed writes from that worker's previous rounds. The README and API comments distinguish these guarantees: previous deletes and claims are visible to the next query, and re-fetching is needed when processing depends on concurrent changes by other writers. Immutable events can pass their values through the batch, including when the worker deletes them after processing.
The queue, LLM, and e2e examples re-fetch IDs and validate current rows before applying effects. Regression tests cover edits, deletes, and direct replay of previously processed arguments. The aggregate example documents its immutable event assumption and exclusive cursor. Guidance also explains why patching by ID does not validate values returned by an older query.
Validation for the documentation follow-up:
npm run build,npm run typecheck,npm run lint, Markdown formatting, andgit diff --checkpassed. All five edited TypeScript files were verified to contain comment-only changes.