feat: add order-by logic to database queries

[xelab04]

Refer to #490

[xelab04]

https://docs.rs/sea-query/latest/sea_query/query/trait.OrderedStatement.html
The sea query docs make a reference to order_by_expr which takes expr: SimpleExpr, order: Order

I'm not exactly sure how to plug sea query into this?

[xelab04]

Right, updated it to use seaquery's own order_by method. I'm not getting the types down for the time being, will work on it more later.

[xelab04]

I have changed it so that instead of ordering on a string of the field name, it uses the fieldref identifier.
So, it would look something like this:

use cot::db::model;
use cot::db::query::Query;
use sea_query::Order; (?)

#[model]
struct User {
    #[model(primary_key)]
    id: i32,
    age: i32,
}

let query = Query::<User>::new().order_by(User::age, Order::Asc);

Last bit is the ownership because it's not happy with the .clone()
And of course, tests

[seqre]

Hey @xelab04, how it's going with this PR? Do you need any help from us?

[ElijahAhianyo]

Hey @xelab04, How's it going with this PR? We're thinking of getting this PR in for the next release planned for this week. I see this is mostly done, and if you don't mind, I would love to finish this if you don't have the time.

[xelab04]

Hi @ElijahAhianyo I had forgotten about this PR till recently because of a series of illnesses. My apologies.

Yes, I remember having mostly completed the PR, but was particularly stumped with creating the proper tests for it. I'd be really happy if you could complete it; I'll also use the opportunity to better understand how I should have done it.

I'm sorry it's been in draft for so long.

[ElijahAhianyo]

Hi @ElijahAhianyo I had forgotten about this PR till recently because of a series of illnesses. My apologies.

Yes, I remember having mostly completed the PR, but was particularly stumped with creating the proper tests for it. I'd be really happy if you could complete it; I'll also use the opportunity to better understand how I should have done it.

I'm sorry it's been in draft for so long.

Ah, no worries. I'll take this up from here and also wish you a speedy recovery. Thanks a lot for your contribution!

[codecov]

Codecov Report

❌ Patch coverage is 88.88889% with 18 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
cot/src/db/query/expr.rs	76.74%	7 Missing and 3 partials ⚠️
cot/src/db/query/expr/order_by.rs	95.95%	3 Missing and 1 partial ⚠️
cot/src/db/query.rs	84.21%	2 Missing and 1 partial ⚠️
cot/src/db.rs	0.00%	0 Missing and 1 partial ⚠️

Flag	Coverage Δ
rust	90.07% <88.88%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
cot/src/db/fields.rs	87.71% <ø> (ø)
cot/src/db.rs	83.98% <0.00%> (-0.09%)	⬇️
cot/src/db/query.rs	86.47% <84.21%> (-0.29%)	⬇️
cot/src/db/query/expr/order_by.rs	95.95% <95.95%> (ø)
cot/src/db/query/expr.rs	79.16% <76.74%> (+5.17%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[seqre]

Is this something to handle in this PR or a follow-up?

[ElijahAhianyo]

yeah, Implementing Expr::concat is out of the scope of this PR. There's an issue here.

[m4tx]

This looks pretty good. Please have a look at my comments, and after these are addressed, I think we could merge this.

[m4tx]

Looks good to me!