feat(cli): merge help output across builtin and project commands - #666
ElijahAhianyo wants to merge 10 commits into
Conversation
|
| Project | cot |
| Branch | elijah/cot-cli-proxy/stack-4-help |
| Testbed | github-ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| empty_router/empty_router | 📈 view plot 🚷 view threshold | 13,540.00 µs(+27.55%)Baseline: 10,615.76 µs | 18,963.91 µs (71.40%) |
| json_api/json_api | 📈 view plot 🚷 view threshold | 996.92 µs(-2.33%)Baseline: 1,020.66 µs | 1,345.80 µs (74.08%) |
| nested_routers/nested_routers | 📈 view plot 🚷 view threshold | 969.75 µs(+1.01%)Baseline: 960.08 µs | 1,248.08 µs (77.70%) |
| single_root_route/single_root_route | 📈 view plot 🚷 view threshold | 925.93 µs(+0.23%)Baseline: 923.85 µs | 1,210.59 µs (76.49%) |
| single_root_route_burst/single_root_route_burst | 📈 view plot 🚷 view threshold | 18,177.00 µs(+7.82%)Baseline: 16,857.97 µs | 22,038.64 µs (82.48%) |
67ea649 to
34b4732
Compare
34b4732 to
972e7b3
Compare
972e7b3 to
93d3b1e
Compare
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
93d3b1e to
c9e4a5f
Compare
c9e4a5f to
7fc660c
Compare
b800429 to
29684aa
Compare
29684aa to
03308ce
Compare
cf245f0 to
1e00dcf
Compare
|
I played around with this and it seems to be working just fine. I even had to check the output of an old version of cot-cli because it was so seamless! Good job! The only confusing part that's remaining is that running a server command seems to be printing out invalid binary name: Whereas when using I don't consider it a merge blocker (especially since the fix won't necessarily be trivial), but we should definitely create an issue for this. |
b786aaf to
9d3c305
Compare
Ah right. Yeah, just created an issue here: #679 |
…inistic task group command order
9d3c305 to
6eeecfe
Compare
Description
This PR merges the help text from the project's binary commands into cot-cli's help text. This is more of a best effort. When we can't locate the binary or extract metadata information, we fall back to the generic help text generated by Clap, which will not contain commands present in the project binary.
When there's a command present in both cot-cli and the project binary, we merge them
Type of change