Repository navigation
Keep gitignore bracket expressions within path segments - #163
Open
xingzhao-ji wants to merge 1 commit into
Open
xingzhao-ji wants to merge 1 commit into
xingzhao-ji wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitIgnoreSpec.from_lines(['a[!x]b']).match_file('a/b') currently returns True, unlike Git. Ranges spanning / and the POSIX punct, graph, and print classes have the same problem. Exclude / while translating these brackets so matches stay within a path segment.
The regression produces 117 failing subtests before the fix and passes afterward. The full three-backend suite runs 270 tests with one skip. Each selected Git-oracle backend run has zero mismatches across 155,448 comparisons; spec APIs use that backend, while byte-pattern APIs use Python regex in every run. Unusual mixed range/POSIX forms retain their existing behavior.