Repository navigation
fix(desktop): close local terminals during shutdown - #652
Merged
Merged
Conversation
forhappy
marked this pull request as ready for review
November 5, 2026 09:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a repository starts a local terminal. On Windows, that terminal kept Crab running after Electron reported quit. Close local terminals during shutdown, reject starts that race with quit, and wait for the native agent to release its storage sessions. Durable daemon sessions continue to run.
Route dashboard and repository inspection commands through the shared Git launcher so Git cannot inherit the agent’s RPC input. The packaged repository smoke now checks that dashboard activity is returned. Retry locked dependency installation and unsigned packaging once after observed GitHub download failures.