Skip to content

fix(desktop): close local terminals during shutdown - #652

Merged
forhappy merged 6 commits into
crab-v2from
codex/fix-alpha-windows-shutdown
Nov 5, 2026
Merged

forhappy merged 6 commits into
crab-v2from
codex/fix-alpha-windows-shutdown

Conversation

@forhappy

@forhappy forhappy commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Opening a repository starts a local terminal. On Windows, that terminal kept Crab running after Electron reported quit. Close local terminals during shutdown, reject starts that race with quit, and wait for the native agent to release its storage sessions. Durable daemon sessions continue to run.

Route dashboard and repository inspection commands through the shared Git launcher so Git cannot inherit the agent’s RPC input. The packaged repository smoke now checks that dashboard activity is returned. Retry locked dependency installation and unsigned packaging once after observed GitHub download failures.

  • Windows packaged shutdown qualification: updater, local repository, live RustFS operations, and saved credentials after restart passed with the shutdown changes.
  • Windows native Git qualification: rebuilt sidecar opened and read a repository, returned activity, pulse, and branch health, then exited cleanly.
  • Electron build and type checking, 32 terminal tests, real local PTY shutdown on macOS and Linux, and the native sidecar release build passed.
  • The combined Windows installer run passed updater, repository and dashboard, and live storage with restart. The tagged release independently builds and runs all packaged smoke checks before publication.

@forhappy
forhappy marked this pull request as ready for review November 5, 2026 09:29
@forhappy
forhappy merged commit 7e8aa45 into crab-v2 Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant