Skip to content

Fixed Evaluation Registry #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pabloitu merged 1 commit into from
Oct 12, 2026
Merged

Fixed Evaluation Registry #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions floatcsep/evaluation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import datetime
import logging
import os
from typing import Dict, Callable, Union, Sequence, List, Any

Expand All @@ -10,6 +11,8 @@
from floatcsep.infrastructure.registries import ExperimentRegistry
from floatcsep.utils.helpers import parse_csep_func

log = logging.getLogger("floatLogger")


class Evaluation:
"""
Expand All @@ -29,6 +32,9 @@ class Evaluation:

_TYPES = {
"number_test": "consistency",
"pseudolikelihood_test": "consistency",
"MLL_magnitude_test": "consistency",
"resampled_magnitude_test": "consistency",
"spatial_test": "consistency",
"magnitude_test": "consistency",
"likelihood_test": "consistency",
Expand Down Expand Up @@ -273,6 +279,9 @@ def compute(
)

evaluation_result = self.func(*test_args, **self.func_kwargs)
if evaluation_result is None:
log.info(f"[{self.name}] no result for {model.name} in {timewindow} (test not applicable)")
return

if self.type in ["sequential", "sequential_comparative"]:
self.results_repo.write_result(evaluation_result, self, model, timewindow[-1])
Expand Down
Loading