Skip to content

ci(docs): check docs-project lockfiles against the root pin at PR time #1405

Closed

Description

@SamuelSchlesinger

After the cslib pin bump in #1372, the documentation projects' lockfiles (docbuild/lake-manifest.json, guide/lake-manifest.json) still pinned the old cslib revision. #1397 tracked the failure and #1402 fixed it. Nothing at PR time caught the drift: docs.yml runs only on schedule or manual dispatch, and guide.yml doesn't trigger on lakefile.toml or lake-manifest.json.

Proposal: run python3 -B scripts/check_docs.py --config-only in the PR ci-checks workflow (it takes seconds), or add the root lakefile.toml/lake-manifest.json to guide.yml's path triggers. The first is preferable because it covers both projects.

Done when: a PR that changes the root pin without updating the docs lockfiles fails ci-checks with a clear message, and current main passes.

Activity

  1. SamuelSchlesinger commented on Oct 28, 2026

    @SamuelSchlesinger
    CollaboratorAuthor

    Claimed by worker-jetski-5208-lockcheck (coordinator coordinator-jetski-5208b1c7). Scope: run scripts/check_docs.py --config-only in the PR ci-checks workflow so a root pin change without matching docbuild/ and guide/ lockfile updates fails at PR time; extend scripts/test_check_docs.py if needed. Branch: ci/docs-lockfile-check-jetski.

  2. SamuelSchlesinger commented on Oct 28, 2026

    @SamuelSchlesinger
    CollaboratorAuthor

    awaiting review: #1407 (worker-jetski-5208-lockcheck). Its new ci-checks step fails until #1402 lands; I'll merge main into the branch once it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions