Skip to content

refactor(Schonhage): namespace native product register aliases #1617

Closed

Description

@edemaine

Available after #1615; bounded follow-up to its outside review, within #1394.

Public register abbreviations in QueriedProduct collide with the finite Schonhage.tiles, leaves and bands names. Product cost/correctness proofs consequently spell out the finite namespace, and the upcoming caller adapter needs both APIs together. In Product/Program.lean, place register aliases such as tiles, leaves, bands, output, index and value in a small QueriedProduct.Reg namespace, or adopt a consistent register prefix after inspecting existing native conventions. Keep the general finite vocabulary unchanged.

Migrate all native Product modules, tests and the real caller-adapter clients together; remove superseded aliases under the repository compatibility rule. Show a checked client using both finite tile/leaf definitions and native registers without full namespace disambiguation. Preserve the fixed program, register numbers, execution/resource statements and source credit; verify native token/body identity apart from renamed references. Update affected module/PR documentation, assess abstracts, complete required validation and obtain API review of the public rename. No mathematical or runtime claim changes are intended.

This is a concrete optional API cleanup, not a new blocker on the reviewed #1615 implementation. Check ownership and current PR heads before claiming; no worker assigned yet. Root coordinator retains the global/static audit queue.

Activity

  1. SamuelSchlesinger commented on Oct 30, 2026

    @SamuelSchlesinger
    Collaborator

    active — Worker jetski-worker-252a2093 (session 252a2093-1f93-43aa-85bf-432251102a3b) claims this bounded API cleanup on branch refactor/schonhage-product-reg-1617 in isolated worktree wt-jetski-252a2093-1617 based on origin/main (af2d9bb95). Prerequisite PRs #1615, #1625, and #1637 are merged on main and no open PR touches QueriedProduct. Next: move all QueriedProduct register abbreviations in Product/Program.lean into QueriedProduct.Reg (matching CallableProduct.Reg and RecordProduct.Reg), migrate all Product/*, Callable/*, RecordProduct/*, and test clients, remove superseded top-level register aliases, and add a checked test exercising Schonhage.tiles/leaves/bands alongside QueriedProduct.Reg.* without full namespace disambiguation.

  2. SamuelSchlesinger commented on Oct 30, 2026

    @SamuelSchlesinger
    Collaborator

    Status: awaiting review

    • Agent / Session: jetski-worker-252a2093 (session 252a2093-1f93-43aa-85bf-432251102a3b)
    • PR: refactor(Schonhage): namespace native product register aliases #1828 (adca42488f2bb6d490fbda8812c62a9e78747907)
    • Validation: All six scripts/check.sh gates and python3 scripts/check_hygiene.py --check-simp passed.
    • Independent Review: Approved by independent review subagent bae9cf39-1487-42a5-83c0-9a7f2a524335 on adca42488f2bb6d490fbda8812c62a9e78747907.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions