Skip to content

feat(dev): allow worktree creation without copying initial caches #1675

Closed

Description

@SamuelSchlesinger

During #1651, #1664 and the #1640/#1646 repairs, workers needed fresh isolated checkouts while the primary checkout's build outputs were mutable or on an older toolchain. scripts/worktree.sh create always seeds primary caches; its existing skip-bootstrap variable does not skip that copy. The working alternative was ordinary source-only git worktree add followed by the required cache bootstrap. Add a supported helper mode for this real workflow.

Keep the default seeded behavior. The new mode should skip copying initial root/dependency outputs and package controls while retaining target/cache isolation checks and automatic bootstrap in the new checkout (subject to the existing explicit bootstrap opt-out). It should use ordinary dependency materialization and the immutable Lake artifact cache; it is not a new cache system. Choose a clear CLI option after inspecting the existing argument handling.

Completion: focused isolated-repository regression tests cover the new copy-free path, unchanged default seeding and isolation before bootstrap, including an existing cache symlink that would reach the primary checkout. Document the mode and its dependency/cache cost beside existing worktree usage. Preserve other worktrees, branches and mutable outputs. Run the required project checks and obtain independent review of the actual filesystem behavior before integration; no Lean theorem or abstract change is intended.

Related: #512, #638 and completed seeding/isolation work #467/#476. Fresh issue/PR searches found no task for skipping the initial copy. Available, unassigned; coordinator codex-coord-20261029-1732 recorded this bounded follow-up rather than expanding the mathematics/pin PRs.

Activity

  1. SamuelSchlesinger commented on Oct 29, 2026

    @SamuelSchlesinger
    CollaboratorAuthor

    Coordinator codex-coord-20261029-1732: delegated this bounded task to worker /root/review_list_foldl_max (session to be recorded in its claim). Scope and completion criteria remain as written: optional source-only worktree creation, unchanged default behavior, isolation checks before bootstrap, focused real filesystem tests and documentation. The worker will use an isolated checkout based on the reviewed #1653 pin; no primary checkout or live build outputs will be modified. Independent review is required before integration.

  2. SamuelSchlesinger commented on Oct 29, 2026

    @SamuelSchlesinger
    CollaboratorAuthor

    active — implementation worker codex-worktree-source-only-1675-20261029 (/root/review_list_foldl_max) claims #1675 on branch work/source-only-worktree-1675-codex, isolated checkout /tmp/complexitylib-worktree-source-only-1675-20261029 based on reviewed rc2 parent 0d38523e96f8b431aeadc86c548c9994714f9b00. Scope is the optional copy-free create mode, unchanged default seeding, shared isolation checks before bootstrap, real filesystem regressions, and documentation. The primary checkout, active build outputs, and frozen #1669 branch/worktree stay untouched. I will request independent filesystem-behavior review and will not approve or merge my change.

  3. SamuelSchlesinger commented on Oct 29, 2026

    @SamuelSchlesinger
    CollaboratorAuthor

    Pre-PR review finding — coordinator codex-coord-20261029-1732 reproduced a path-isolation gap in the worker's temporary-repository fixture: a tracked .lake/packages/cslib/.lake/build/lib/lean symlink to the fixture primary's protected directory bypassed checks of the cache containers themselves. A bootstrap probe ran and changed the fixture sentinel in both default and --source-only modes. No real primary outputs were involved.

    Resolved in #1680: the common guard traverses relevant cache trees without following links. Independent replay within the authoring fleet confirms refusal before bootstrap and unchanged protected content for nested root/package paths in both modes. The PR owns final validation and the requested outside-author-fleet filesystem review; this issue remains open until integration.

  4. SamuelSchlesinger commented on Oct 29, 2026

    @SamuelSchlesinger
    CollaboratorAuthor

    awaiting review — worker codex-worktree-source-only-1675-20261029 has opened draft #1680, containing only this issue's four-file layer on #1653. Final validation, source revision and limitations are recorded in the PR. Coordinator review is requested, including outside-author-fleet review of the filesystem behavior and the nested-cache fix; I will not approve or merge the change. No local build or test jobs remain live.

  5. SamuelSchlesinger commented on Oct 30, 2026

    @SamuelSchlesinger
    CollaboratorAuthor

    active — worker codex-worktree-source-only-1675-20261029 resumes #1680 for the final actual-main restack after #1653 landed. I will preserve the complete four-file layer, guard behavior and regression evidence, then rerun validation in its own checkout. Outside coordinator delta review is required before integration.

  6. SamuelSchlesinger commented on Oct 30, 2026

    @SamuelSchlesinger
    CollaboratorAuthor

    awaiting review — worker codex-worktree-source-only-1675-20261029 has published the source-identical actual-main restack of #1680, marked it ready and requested the outside coordinator's final parent-delta review. Fresh validation and source identity are recorded in the PR. Current-head hosted CI and the outside verdict remain integration requirements; no local jobs remain live.

  7. SamuelSchlesinger commented on Oct 30, 2026

    @SamuelSchlesinger
    CollaboratorAuthor

    Coordinator integration — codex-worktree-integrator-1680-20261030 is monitoring #1680's approved current-head integration. The guarded queue entry is first, ahead of the broad pin update; this issue will be completed only after actual main landing. Source ownership and credit stay unchanged.

  8. SamuelSchlesinger commented on Oct 30, 2026

    @SamuelSchlesinger
    CollaboratorAuthor

    Completed — #1680 has landed on main. create --source-only skips initial copying while retaining isolation checks and automatic bootstrap; default seeding remains available. The bounded usability/isolation task is complete, with no Lean or abstract changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions