Skip to content

fix(dev): reject absent audit outputs before invoking Lake #1712

Closed

Description

@SamuelSchlesinger

The post-build audit helper scripts/lean_outputs.py currently invokes lake build --no-build before checking whether its reference output directory exists. Lake loads/materializes dependencies before rejecting stale targets, so an empty checkout can incur substantial setup work before the audit reports missing outputs. The documented use remains after a build; this does not change the source-only worktree contract.

Add the smallest shared guard: after the explicit skip branch, fail nonzero for an absent reference output directory before invoking Lake. Preserve normal built/CI freshness checks and explicit skip semantics. Add a mocked regression proving Lake is not called for missing outputs, and a short checker-help sentence explaining the post-build prerequisite and Lake side effects. No new source-only mode, weaker audit, broad refactor or promise of read-only execution in partial checkouts.

Completion: focused mocked Python tests, final validation on actual main after the #1694 pin/cache release, all six project gates and relevant script checks, and fresh outside-fleet review of the infrastructure behavior. No Lean, curated-abstract, catalogue or rendering changes are intended. #638 retains its separate shared-dependency-pool objective; #1675/#1680 concern initial worktree copying.

AI assistance: Codex traced the scripts, documentation and installed Lake call paths and will implement this bounded follow-up in an isolated worktree. A distinct worker/session claim follows before edits.

Activity

  1. SamuelSchlesinger commented on Oct 30, 2026

    @SamuelSchlesinger
    CollaboratorAuthor

    active — worker codex-audit-failfast-1712-20261030 (/root/review_kernel_list_1651) claims this bounded helper/help/regression change on branch fix/audit-missing-outputs-1712-codex, new source-only worktree /tmp/complexitylib-audit-missing-outputs-1712-codex-20261030 in the independent coordination repository. Before the #1694 landed-pin/cache release I will run only the fully mocked Python suite, with no Lake/bootstrap or dependency materialization. After the explicit release I will ordinary-merge actual main, use this one owned build tree for final validation, and request outside-fleet review before integration. No Lean or abstract/rendering impact is expected.

  2. SamuelSchlesinger commented on Oct 30, 2026

    @SamuelSchlesinger
    CollaboratorAuthor

    active / held — worker codex-audit-failfast-1712-20261030 has implemented the shared guard, two mocked regressions and the help clarification locally. All 12 tests in scripts.test_lean_outputs pass; .lake remains absent. I am waiting for the #1694 operator's actual landing plus published main-cache mapping before merging main, bootstrapping, running the full gates and publishing the PR.

  3. SamuelSchlesinger commented on Oct 30, 2026

    @SamuelSchlesinger
    CollaboratorAuthor

    held checkpoint — worker codex-audit-failfast-1712-20261030 published 08fe4e17 on the claimed branch. All 12 fully mocked helper tests pass; .lake remains absent. The supported-pin/main merge, bootstrap, full six-gate and consumer checks, and outside-fleet review are still pending. I retain the third disk turn after matrix then hierarchy, subject to the pin/cache release and 10 GB free-space requirement; no PR has been opened.

  4. SamuelSchlesinger commented on Oct 30, 2026

    @SamuelSchlesinger
    CollaboratorAuthor

    held — worker codex-audit-failfast-1712-20261030: the #1694 pin/cache gate is released, and I ordinary-merged supported main 54edc940 locally. The four-file patch is unchanged and the mocked helper suite still passes. Final materialization/validation waits for the third disk turn after matrix and hierarchy; the published checkpoint remains the one above until those checks finish.

  5. SamuelSchlesinger commented on Oct 30, 2026

    @SamuelSchlesinger
    CollaboratorAuthor

    held — worker codex-audit-failfast-1712-20261030 retains the prepared checkpoint, with supported main merged locally and mocked tests passing. Full validation is still waiting for the ordered third disk slot. Next: verify at least 10 GB free, bootstrap this one owned tree, run the six gates and consumer checks, then open the PR and request outside review.

  6. SamuelSchlesinger commented on Oct 30, 2026

    @SamuelSchlesinger
    CollaboratorAuthor

    active — worker codex-audit-failfast-1712-20261030 has the released third disk slot. The owned-checkout preflight found over 10 GiB free and no active build processes; I ordinary-merged current main while preserving the four-file patch. Bootstrap and final supported-pin validation are now running in this one owned tree. PR publication and outside review remain next.

  7. SamuelSchlesinger commented on Oct 30, 2026

    @SamuelSchlesinger
    CollaboratorAuthor

    awaiting review — worker codex-audit-failfast-1712-20261030 opened PR #1714 with final validation and the no-abstract-impact assessment recorded there. Fresh outside-author-fleet infrastructure review is requested. I will not approve or merge this change; #1712 stays open until integration.

  8. SamuelSchlesinger commented on Oct 30, 2026

    @SamuelSchlesinger
    CollaboratorAuthor

    Coordinator codex-coord-20261029-1732: completed. #1714 landed as 00231c1f with the reviewed guard/tests/help intact. Outside-fleet review and all required validation passed; its unchanged script blobs were verified in the successfully validated/published main descendant d0d220c9. Single final integration record. No intermediate run was restarted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions