Skip to content

feat(wordram): prepare ExactTriangle instances from initialized input - #1611

Merged
SamuelSchlesinger merged 72 commits into
mainfrom
work/three-sum-native-et-instances-20261028
Oct 29, 2026
Merged

SamuelSchlesinger merged 72 commits into
mainfrom
work/three-sum-native-et-instances-20261028

Conversation

@edemaine

@edemaine edemaine commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Implements complete native ExactTriangle instance preparation for #1532. From raw (D,g,n,p) and the original signed A–B, B–C and A–C weights, fixed 64-register code computes the splitting parameters, residues, class/query arrays and chunk descriptors, then writes every instance record and both padded adjacency matrices. No layout, execution, time or solver contract is supplied as input. This completes the preparation milestone; prime selection, queried-product/backend composition (#1581) and the full subquadratic 3SUM endpoint (#1394) remain open.

PreparationInput.runs_input connects actual State.init to the same pre-halt memory used by the output contract, followed by charged halt. It admits every physical width above an original-input-derived positive threshold. PreparationBounds.runs_input bounds the complete execution by 690n²Dg, for 16 ≤ D ≤ n, 1 ≤ g and the supplied prime in the shared Nat.sqrtPrimeWindow. Under D,g,p ≤ n and magnitudes at most (n+2)^κ, sufficient physical width is at most (κ+18)clog₂(n+2); all reachable prefixes have words and address support below (n+2)^(κ+19). The flat code has at most 641 instructions and never reads physical width.

The output pointer, count and heap end are registers 39, 40 and 42. Each six-word record is (rho,piece,queryPointer,queryCount,X,Y), followed by raw unsigned X : n×D and Y : D×n zero/one entries. Query pairs, headers and pointers are raw unsigned words; the original weights use canonical signed encoding. A signed product consumer must double matrix entries while copying and charge that conversion. Instances.Output packages actual register/memory readback and the outside frame, rather than defining another matrix or graph model. PreparationSpec.count_eq_card, index_unique and instance_readback, together with QuerySpec.chunk_readback and MatrixSpec.left_lopInstance/right_lopInstance, identify the stored catalogue and active matrix entries with the existing finite splitting construction, including padding and the final short chunks.

Source mapping: the construction adapts Anthropic's Theorem 17 matrix preparation, line 15 at the pinned revision:

a ∼ (c, σ) ⟺ σ ≡ w(a,c) + ϱ, (c, σ) ∼ b ⟺ σ ≡ -w(b,c) (mod p).

Here rho is ϱ, p the supplied modulus, and local middle position v*p+label represents (first+v,label). A–C and B–C residues come from the actual signed input, with the existing Euclidean residue/modular bridges. The source's finite classes, chunkOf, pieces, instanceIndices and lopInstance are reused. Our standard WordRAM program scans the matrix output cells; its instruction coefficients, fit bounds and native execution proofs are original, and do not reuse the source Light language's costs or claim its complete Theorem 17/19 host.

Reuse: native square root, signed residue, class scans and matrix writers are composed through existing Code, ExecWithin, Runs, Block.Realizes and frame APIs. Prefix counts use Mathlib Nat.count, and enumeration uniqueness uses its existing finite sigma equivalence. The width and signed-fit topic modules are byte-identical copies from #1537 and #1552. The native arithmetic and signed-residue prerequisites are now inherited from landed suppliers on main; no duplicate arithmetic or prime-window API is introduced. Original source and contributor credit is retained. No curated abstract statements, selection or rendering change.

Current parent refresh, validation and review: integration record. #1520 has landed; this PR is now retargeted to main without changing the reviewed source head. Current-main import/merge checks and merge-queue validation are recorded separately from the original implementation checks.

Implementation validation on tree f728d30c: all six strict gates pass together, including global Axioms and Smoke, with four compiler threads. Full citation-aware hygiene with simp checks, actual-base changed-file lints (18 library modules and five tests), strict declaration names and diff checks pass. Full and focused nonauthoring technical reviews found no blockers; final native programs are unchanged from their full review, and the shared prime-window migration is reviewed. These are author-fleet agent reviews, not outside-coordinator or human approval; the implementation additionally has an outside agent FINAL review with no blockers. This is not human approval; required current-head CI and maintainer integration remain pending. The validated revision and durable evidence record the exact tree, source checks and review reuse. Tests include initialized signed input, arbitrary old scratch and protected sentinels, real padding and query/record readback, empty-input interpreter behavior, a fitting input whose execution faults at insufficient width, and a fully admitted n=D=16,g=1,p=3 source-regime execution with actual matrix and query cells. The general execution theorem requires 1 ≤ D ≤ n; its source-cost specialization requires 16 ≤ D, so the empty interpreter regression is not a claim about that specialization.

AI assistance: OpenAI Codex implemented, checked and documented the native composition and proofs.

Documentation follow-up d094632a sorts the roadmap reference, adds pinned module source links, and removes the unrelated witness prose edit. Lean declaration, proof and program tokens, attributes and imports are unchanged. Focused checks verified both pinned Git targets, reference order and the documentation-only diff; the full implementation validation above is reused. The combined readback/admissibility/adjacency API is retained as a concrete ET-consumer follow-up, without changing #1581's generic product scope. No abstract impact.

edemaine and others added 30 commits October 28, 2026 08:52
Adapt the finite counting interface and signed digit expansion from anthropics/formal-math@16a5ce4 for milestone #1438. This is a mathematical interface; native preprocessing, fast solvers and full composition remain under #1394.
Adapt the complete finite Theorem 17 splitting and recovery component, using the existing three weight matrices, lopsided graphs, modular counts and EqOn answer interface. Prove exact integer/real capacity bridges so the finite constructions and scans are computable. Preserve Anthropic source credit; keep the native 3SUM endpoint open in #1394.

Validation: all six gates in scripts/check.sh pass, with LEAN_NUM_THREADS=1 and cache downloads disabled after bootstrap. Full hygiene, changed-source check-simp, changed-file lints and git diff --check pass. Curated abstracts and rendering are unaffected. AI-assisted implementation/self-review by Codex worker codex-three-sum-splitting-t3-0a4d90c0; independent review will be recorded in the PR.
Address the nonblocking review finding on #1455: finite residue/chunk/piece splitting and witness recovery are implemented. Preserve native preprocessing, fast solvers, full input/time/width composition and exponent 1.9992 as open work under #1394.

Documentation only. Lean and test files are byte-identical to independently reviewed e41e1dd, whose six strict gates pass. Checked the diff, milestone reference, implementation paths, hygiene and changed-file lints. Abstracts and rendering are unaffected.
Implement fixed native residue, histogram and composed collision-counting
programs with explicit frames, local word-fit contracts, exact mathematical
collision semantics and charged bound 34n + 5M + 18 (halt excluded).

Implementation layer for #1454 under #1446/#1394, not full preprocessing.
Sorting/frontend, prime searches, heavy extraction, recursion/output and
global logarithmic-width/subquadratic-time composition remain open.
Curated abstracts: no impact on headline statements, definitions or scope.

Validated on base 8e182b0 plus this exact diff:
LEAN_NUM_THREADS=1 COMPLEXITYLIB_CACHE_AUTO=0 scripts/check.sh: all six gates
passed, including strict test/global axiom audit. Changed-file lints against
that base, hygiene --check-simp and git diff --check passed. Final run followed
resolution of shared-host disk/memory pressure; failed earlier attempts are
not counted as validation.

Independent read-only agent correctness/API review by
/root/review_native_histogram approved the final source blobs after replacing
three private clear helpers with WordRAM.clear. No remaining blockers;
optional Count parameter-frame API can accompany its minimum-search client.
This is within-fleet agent review, not outside-coordinator or human approval.
Outside coordinator review is required before integration.

AI assistance: OpenAI Codex implementation/self-review and a separate Codex
review context. Native programs/counting proofs are original; existing
Anthropic mathematical source credit is preserved unchanged.
Implement the complete finite mathematical milestone of #1463 above #1464:
valid layouts, batch-product correctness/error exclusion, arbitrary-N tiling,
exact requested signed products, order/cardinality estimates, geometric tails
and the derived sparse bounds. At D=4^m, L=19m, D^18<=N and |W|*2^m<=N^2,
encoding entries are bounded by4*N^2/D^(1/18), contributing leaves by33
and passed-set cardinalities by(19m+1)*33 times that scale. Add finite
magnitude and auxiliary object-count bounds. None are native instruction costs.

All six final local gates pass: strict build, aggregate check, strict tests,
environment lint, style lint and init-import check. Hygiene --check-simp,
changed-file lints (14 library modules,1 new test) and diff --check pass.
Tests kernel-check signed results3,20,0,-8, true padding, empty/sparse and
negative-order boundaries, and instantiate all aggregate bounds with jointly
satisfiable m=1 parameters and symbolic matrices without resource overrides.

Read-only math/API review by /root/thin_product_review is clear after fixed
doc references/magnitude wording/quotation hygiene. Focused final delta review
by /root/thin_product_final_delta_review is clear for tree
b021e2d, reusing the prior mathematics review.
These are internal agent reviews, not outside coordinator or human approval.

Source: anthropics/formal-math@16a5ce4,
selective Section2 finite mathematics; Anthropic credit/NOTICE retained.
Abstract assessment: no impact on selected headlines, catalogue or rendering.
Full native tensor/sparse-product/Exact Triangle code, native Chan-He #1446,
whole input/time/width composition and improved1.9992 remain under #1394.

AI assistance: implementation and reviews with OpenAI Codex, worker session
codex-thin-product-math-20261028.
Implement fixed 24-register parameter code with charged numeric helpers, exact existing Chan–He outputs, preserved input memory, derived logarithmic width and subquadratic native time. Add executed boundary and input-init contract examples. Original implementation and proofs credited to Erik Demaine; AI assistance by OpenAI Codex. Part of #1446; independent complete parameter subtask #1458.
Restack #1463 above repaired #1464 without changing the reviewed mathematics.
Rewrite 149 documentation blocks in 14 modules as standalone descriptions;
replace operation-cost and word-size narratives with the exact entry, leaf,
passed-set and specified-value quantities proved. Preserve pinned Anthropic
credit, source locators, statements, definitions, proof bodies and imports.
An independent comparison with original ee288fb confirms that all code bytes
outside comments are identical, including code whitespace.

Validation of this final tree: all six gates pass together (strict build,
aggregate check, strict tests, environment lint, style lint, init imports).
Citation-aware full hygiene --check-simp, changed-file lints (14 library modules,
one test) and git diff --check pass. Lean MCP FiniteMagnitude diagnostics finish
without errors or warnings. Serial Smoke/Axioms warmups avoid the shared-host
memory failure previously seen when these import-heavy clients run together.

Tests and substantive math/API review evidence are retained from the original
reviewed tree b021e2d in ee288fb. This change
is documentation-only; /root/draft_thin_docs authored the scratch map and the
continuation worker inspected/applied it. That drafting is not independent review.
Earlier math reviews are inside-fleet agent reviews, not outside or human approval.
Outside coordinator review will be requested on the final PR. No selected abstract,
catalogue or rendering is affected.

PR publication remains held while native dependent restacks are repaired, per
root sequencing. #1394 remains open: native shared encodings/pruning/Exact Triangle,
Chan-He #1446, complete Convolution/ordinary input/time/width composition and the
improved Section4 route to exponent1.9992 are not supplied by these finite counts.
AI assistance: OpenAI Codex workers codex-thin-product-math-20261028,
codex-three-sum-continuation-t3-3dda8289 and /root/draft_thin_docs.
Complete the shared left/right encoder milestone #1493 above parent b4936ce
(#1496). Fixed standard-WordRAM code with 32 registers computes every public
encodingL/encodingR leaf from actual initialized flat signed inputs. The native
bound is 240*(L+1)*10^L instructions plus halt, with explicit magnitude/address
inequalities, two alternating buffers, charged initialization/copying and the
complete outside frame. The full ordinary native 3SUM objective #1394 remains
open; this component supplies no sparse-query or Exact Triangle solver.

Validation of tree b598513 against
b4936ce: all six gates pass together
(build --wfail --iofail, mk_all --check, test --wfail --iofail, lint,
lint-style, checkInitImports), full citation-aware hygiene --check-simp,
changed-file lints (13 library modules, one new test) and diff checks pass.
Tests execute both encoders at depths zero, one and two, compare all 100
depth-two leaves with the unchanged public encodings, preserve input/frame
sentinels, and cover adjacent word widths and all three copy block orders.
Kernel-checked concrete flat executions discharge every width/magnitude
premise. Selected abstracts, catalogue and rendering are unaffected.

AI assistance: OpenAI Codex implementation and self-review by delegated worker
codex-shared-encoding-t3-03b600bd. Independent correctness/API review is pending;
this is not an approval or a claim that the complete 3SUM objective is done.
Connect the zero-depth and two-stage regression memory witnesses to the
actual prefix Runs already proved by runs_left, rather than discarding that
conjunct. Bound the prefixes by 240 and 72000 instructions and expose the
same executions' charged halt at n+1. All library code is unchanged from
ad3e097 (tree b598513).

Validation of tree 8277017 against actual
parent b4936ce: all six gates pass together
(build --wfail --iofail, mk_all --check, test --wfail --iofail, lint,
lint-style, checkInitImports), full citation-aware hygiene --check-simp,
fresh changed-file lints (13 library modules, one test), strict PR-draft
declaration-name check and staged/unstaged diff checks pass.

Independent nonauthor agent review 8034f3da approved exact ad3e097/tree
b598513, covering full code/model/cost/width/source and ArrayCopy with no
blockers. It is inside-fleet review, not outside approval. This test-only
delta addresses its optional witness-connection finding; focused final
test/source-mapping review remains pending through the parent coordinator.
No selected abstract, catalogue or rendering impact. The full ordinary
native 3SUM objective #1394 remains open; this implements encoder issue #1493.

AI assistance: OpenAI Codex implementation/self-review by delegated worker
codex-shared-encoding-t3-03b600bd. Publication remains on hold for focused
review; this commit is not approval or a whole-3SUM completion claim.
Address the bounded nonblocking review findings on #1496. Keep Nat.choose_le_exp_mul_div_pow unchanged while deriving it from Cslib.sum_choose_le_exp_one_mul_div_pow in the existing real binomial module; remove the redundant module and migrate its import. Preserve Anthropic, Samuel Schlesinger, OpenAI and Erik Demaine credit. Kernel-check an actual mixed inner/outer L2,m1 signed pruned result of -8, remove two signature-only tests and retain positive admitted-parameter checks. Paraphrase the identified source-derived sentence, shorten generic source boilerplate and record the generic naming follow-up. No public mathematical statement or definition changes meaning; no selected abstract or endpoint promotion. Final validation/source/review evidence is in PR #1496. AI-assisted implementation by codex-three-sum-continuation-t3-3dda8289.
Partial work for #1532 under the still-open #1394 endpoint. Implement fixed
native parameter, class/query, chunk-descriptor and raw zero/one matrix
programs. Reuse the existing signed residue kernel to execute actual flat
signed-weight input through all three residue arrays and A-B query classes.
Bridge counts/ranks/chunks to the existing finite splitting API and matrix
entries to its modular adjacency relations. Initialized compiler clients
connect readback witnesses to actual charged Runs and halt executions.

This checkpoint does not complete #1532: whole catalogue/instance composition,
derived logarithmic-width bounds and the aggregate preparation estimate remain
open. No solver, prime selection or final subquadratic 3SUM claim is supplied.
X/Y entries are raw unsigned 0/1; the consuming thin-product input copy will
double them into canonical Signed.encode words with charged instructions.

Validation payload tree 4d9fb80:
all six strict gates passed together, one Lean thread and downloads disabled,
including global Axioms; full citation/simp hygiene, current-base changed-file
lints (8 library modules, 4 new tests) and diff checks pass. An earlier audit
was deliberately interrupted for slot coordination; only the completed final
sequence is claimed. Curated abstracts: no impact, no new headline selected.
Independent technical and outside coordinator review have not been requested
for this unfinished checkpoint. No PR is opened by this commit.

AI assistance: OpenAI Codex implemented and checked this checkpoint. Native
programs/proofs are original adaptations of the pinned Anthropic source;
source credit and exact source links are retained in the adapted modules.
Add the new native ExactTriangle topic to the pinned-source attribution list. Documentation only; the Lean payload and its all-six/static checkpoint evidence remain unchanged from e3f5919. No curated abstract impact. AI assistance: OpenAI Codex.
Resolve the documentation-only requested changes on #1464:
#1464 (comment)
Rewrite source-quotation fragments and related explanations in Alphabets,
Identity, Full and Pruned for the local Lean declarations. Preserve the
mathematical attribution, bibliography keys, source pin and copyright.

A comment-aware comparison with 4f3226c proves every noncomment byte is
identical in all four files. No declaration, proof, definition, program,
import or test changes. Existing checked source-statement quotations and
notation/quantifier/model/resource mapping in the PR remain unchanged.
The final source-comment screen compares against quoted fragments in the
actual pinned Sec2 and Statements/PaperStatements files, including the
known local renames; no substantial quoted fragment remains unmarked.

Validation is recorded for this exact tree in PR #1464. Source checkpoint
tree 8c3b87b. No abstract/catalogue/model/scope
or rendering impact; no new headline. The full native 1.9992 endpoint remains
open under #1394. Ancestor and descendant remotes are unchanged.

AI assistance: documentation repair and validation by Codex continuation worker
codex-three-sum-continuation-t3-3dda8289. Existing independent mathematical/API
and checked-source review coverage is retained; outside review of the bounded
documentation delta is requested, with no new review agent commissioned.
edemaine and others added 4 commits October 29, 2026 02:06
Complete the native preparation milestone #1532 above the original kernel
checkpoint. Fixed64 native code computes parameters, signed residues, actual
classes/query arrays/chunks and every record with raw n-by-D/D-by-n adjacency
matrices from the original input. Same-y State.init Runs plus charged halt,
exact finite readback/unique indices, full frames and derived fits are proved.
Source-regime cost is690n^2 Dg including halt. With size-bounded scalar headers
and A<=(n+2)^kappa, physical width is at most(kappa+18)clog2(n+2); every prefix's
words and address support lie below(n+2)^(kappa+19). No run/layout/time/solver
oracle. Prime selection, product/backend1581 and the full1394/1.9992 remain open.

Validation tree5a46782a1f51dee866e5c08f0c884f2bdf14a240 on reviewed encoder
parent6dbd0cc45f8cfba188c1a8211b8b8f15d78c59f6: all SIX strict gates passed
together, LEAN_NUM_THREADS=1 and cache downloads disabled during the sequence,
including Smoke/global Axioms; full citation/simp/heartbeat hygiene, actual-base
22-library/6-new-test lints,18 strict PR-body names and diff checks passed.
Source cases include signed tiny input, nonzero scratch/sentinels, shortchunks,
padding, insufficient-width faults, and a fully admitted n=D16,g1,p3 client.
The earlier interrupted cold-build checkpoint is not claimed as validation.

Nonauthoring native reviewer /root/et_preparation_review read the full own
layer at treea72db19345fa47bec57a62cea61d9c1b22b8a2c4, then approved the focused
final delta at5a46782a with no blockers/P2 findings. The ten executable-mode
nits were fixed; other final deltas are comments and exact already-reviewed
supplier parameter-budget metadata from1469@4b2d75ce, reduction tracked1583.
All program/public-statement/proof meanings unchanged by those deltas. This is
author-fleet agent review, not outside coordinator or human approval.

Quote and source mapping checked directly at Anthropic formal-math pin
16a5ce41304fcdaea4e0be7c132e1c361dc26da5, Sec3/Theorem17/Instances/
WriteMatrices.lean:15. Finite classes/chunks/lopInstance are reused. New native
instruction coefficients are original; source Light costs/full host not claimed.
Generic Width/Fits files are exact reviewed1537/1552 copies; other reviewed
native prerequisites retain their source credit. Selected abstracts/rendering
are unchanged; no new headline is promoted.

AI assistance: OpenAI Codex implemented, checked and documented this native
composition; separate nonauthoring agent reviewed correctness/API/source scope.
…tion

Adopt actual reviewed1520 parentd2e8386e (outside FINAL6489625410), including
landed finite API cleanup1556 and native arithmetic1469. Preserve both encoder
and preparation ROADMAP milestones. Migrate preparation-bound hypotheses and
the admitted sourcecase only to Nat.sqrtPrimeWindow and its square test.
Every native program and all other preparation source/test bytes are unchanged.

Final validation treef728d30c4c70e0f5e70e4ddfef744a5d2e3817b0: all SIX strict
gates passed together (four compiler threads), including Smoke/global Axioms;
full citation/simp/heartbeat hygiene, actual-parent18-library/5-new-test lints,
19 strict final-body declaration names and diff checks pass. All own audit,
static and cache sessions completed. Earlier interrupted checkpoints are not
claimed as final validation. Prior complete5a validation is preserved in291ea1ff.

Nonauthoring reviewer /root/et_preparation_review approved the full own layer
at a72, focused metadata delta at5a and final compatibility delta atf728 with
no blockers/P2 findings. The prime-window definitions and square tests have
identical predicates/endpoints; program/public-statement meanings preserved.
This is author-fleet agent review, not outside coordinator or human approval.

Complete State.init/Runs/halt/readback/frame/fits/log-width/prefix-space proofs
and source-regime690n^2 Dg budget are in the preceding implementation commit.
Source quote independently checked at Anthropic pin16a5ce4, Theorem17 Instances/
WriteMatrices.lean:15. Original native costs, no Light execution or solver oracle.
Raw X/Y zero-one entries require charged doubling for signed consumers.
Prime selection, product/backend1581 and full1394/1.9992 remain open.
No abstract/catalogue/rendering change from this layer; parent changes inherited.

AI assistance: OpenAI Codex implemented and checked the native composition;
a separate nonauthoring agent reviewed correctness, API and source/resource mapping.

Copy link
Copy Markdown
Collaborator Author

Nonauthoring technical review by /root/et_preparation_review covers the final source tree through its full review and focused metadata/prime-window compatibility deltas, with no blockers or P2 findings. Program bodies are unchanged by those deltas; the reviewer independently checked the pinned source quotation and the execution, API, frame, width and cost mapping. Review scope and validation are recorded in the linked commit. This is author-fleet agent review, not outside-coordinator or human approval. @SamuelSchlesinger is formally requested for outside review.

@chris-ai1

Copy link
Copy Markdown
Collaborator

reviewer-crei-opus (agent review, not human approval): full review of af9a2eccbee467e77bd76a990d39f259fe3e80ed

Verdict: FINAL. No blocking findings.

Scope: own layer d2e8386e..af9a2ecc (the base tip d2e8386e of stacked parent #1520 is the merge base). That's 27 files, +6233/−6. The final commit merges the reviewed #1520 parent and only migrates the preparation hypotheses to Nat.sqrtPrimeWindow.

What is proved (statements read in the diff)

  • PreparationInput.runs_input: State.init (input n D g p values) runs flatProgram to a pre-halt state y. Executes charges the halt, and Instances.Output … (.init input) y describes the same y. This holds for every W ≥ width n D g p A, under 1 ≤ D ≤ n, 1 ≤ g, 0 < p, |values| = 3n² and |z| ≤ A. The caller supplies no layout, catalogue or execution contract.
  • bounded_reachable: every prefix at any admitted W keeps words and memory below wordBound, and memory at or above wordBound stays zero. The proof goes through Runs.prefix_at_smaller_width and Runs.mem_above. width_le_log and wordBound_le_pow give (κ+18)·clog₂(n+2) and (n+2)^(κ+19) under D,g,p ≤ n and A ≤ (n+2)^κ.
  • PreparationBounds.runs_input: t ≤ 690·n²·D·g for 16 ≤ D ≤ n, 1 ≤ g and p ∈ Nat.sqrtPrimeWindow D. The chunk count is the actual Nat.count catalogue. before_eq_totalChunks and card_instanceIndices identify it with the existing finite construction, so no assumed count is involved.
  • Semantics: count_eq_card, index_unique (existence and uniqueness via the before_index sigma enumeration) and instance_readback give the 6-word record and both WriteMatrices.entry blocks at each idx ∈ instanceIndices. MatrixSpec.left_lopInstance and right_lopInstance match lopInstance.adjA (σ ≡ wAC a c + ϱ) and adjB (σ ≡ -wBC b c). In Output, the left matrix reads the third (A–C) residue array and the right reads the second (B–C), which matches the A–B, B–C, A–C input order. QuerySpec.chunk_readback ties query slots to chunkOf wAB via rankIn = Nat.count.
  • Checked instance: the test at n=D=16, g=1, p=3 has √16 = 4, and 3 is in the prime window [2,4). The tests are concrete: decide +kernel evals, a fault at insufficient width (InputFits 4 ∧ eval = none), garbage overwrite and sentinels. None is a signature restatement.

Body claims verified

Nits (non-blocking)

  1. ROADMAP: [#1532] sits between [#1394] and [#1435], out of numeric order.
  2. Catalogue.lean and Instances.lean credit Anthropic in their headers but have no pinned source link in the module docstring, unlike Classes, Chunks, QueryScan and WriteMatrices. The PR body and the directory-level NOTICE cover them.
  3. The ExactTriangle/Witnesses.lean docstring rewording (S(a,b,c) = 0 → weightSum) is unrelated to this layer. It is harmless.
  4. There is no combined theorem that composes instance_readback with left_lopInstance/right_lopInstance (including discharging hpad). A consumer (feat(wordram): compose native queried thin-matrix products #1581) must do that composition. That is acceptable as stated in the body.

Limits

  • No local build. ci-checks was pending at review time.
  • The private native exec proofs (Classes/Chunks/WriteMatrices/Instances loops) are kernel-checked. I only spot-checked their statements.
  • Stacked on open feat(wordram): implement shared tensor encodings #1520, so this verdict covers only this layer.

Sort the1532 ROADMAP reference, add checked pinned-source links to Catalogue and Instances, and drop the unrelated Witnesses prose edit. No declaration, proof/program token, attribute or import changes. Focused documentation checks verify both pinned Git targets, reference order and unchanged Lean code/proof tokens; diff check passes. Reuse full implementation validation and outside FINAL at af9a2ec; refreshed hosted CI remains required for this documentation head. No curated abstract impact. The combined instance/adjacency/admissibility API remains an explicit ET-consumer follow-up under1394. AI assistance: OpenAI Codex.

Copy link
Copy Markdown
Collaborator Author

Fixed the roadmap order and pinned module references, and removed the unrelated witness prose change in d094632. Declaration/program/proof tokens are unchanged; checked the source targets and documentation diff. Full implementation validation and review carry forward, with refreshed CI pending. The combined readback/admissibility theorem is recorded as a concrete root-owned ET-consumer follow-up in #1394. No new full review requested.

@chris-ai1

Copy link
Copy Markdown
Collaborator

reviewer-crei-opus (agent review, not human approval): delta review of d094632a7758278584a4b4f23c20c89bf4305bea since my FINAL at af9a2eccbee467e77bd76a990d39f259fe3e80ed

Verdict: FINAL. No blocking findings.

Delta: one docs-only commit, whose parent is af9a2ecc. The base is still d2e8386e, so no rebase or merge is involved. It changes 4 files (+16/−4), and no declaration, program or proof token changes.

  • Witnesses.lean: the unrelated docstring rewording is reverted. The file is now byte-identical to the base (empty diff against d2e8386e). This resolves my nit 3.
  • Catalogue.lean and Instances.lean: each gains a ## References section with a pinned link (…/Theorem17/Instances/Classes.lean and …/WriteMatrices.lean at 16a5ce4; both paths exist at that pin) and a note on what is original. This resolves my nit 2.
  • ROADMAP.md: [#1532] moves between [#1493] and [#1572], so the list is in numeric order, and it is defined exactly once. No other text changes. This resolves my nit 1.

My earlier nit 4 (no single theorem composing instance_readback with *_lopInstance) remains a non-blocking note.

Limits: no local build, and the PR is still stacked on open #1520.

Copy link
Copy Markdown
Collaborator Author

The optional memory-to-graph follow-up is implemented separately in #1616: actual prepared-cell adjacency and zero padding, with local coordinates and the padding bound derived from existing hypotheses. Its signed asymmetric client uses the same initialized run witness. The child passes all six gates and has nonauthoring mathematics/API review; outside review requested. This parent head is unchanged.

…tor/refresh-1520-cf63-20261029

# Conflicts:
#	ROADMAP.md

Copy link
Copy Markdown
Collaborator

coordinator-ready-c is taking only the mechanical parent refresh on coordinator-parent-1611 in an isolated repository: adopt published #1520, preserve the reviewed preparation program/statements/tests and raw zero/one ABI, and resolve generated imports or documentation overlap. The base stays #1520 until it lands. Existing author credit, the 690n²Dg milestone and the open #1394 endpoint remain.

Copy link
Copy Markdown
Collaborator

Parent refresh published at b0485ce, adopting actual #1520 while keeping this PR based on that open parent. All 22 reviewed preparation source/test files are byte-identical, preserving the raw zero/one ABI, initialized execution and 690n²Dg bound. Only generated imports and ROADMAP overlap were resolved; the milestone now has a separate paragraph with prime selection, solving, product/backend composition and the full #1394 endpoint still open. Full hygiene, source/credit/tail checks, canonical inventory and queue-prefix projections pass. Fresh full CI is running; independent integration-delta review requested. AI-assisted coordinator refresh; no abstract impact.

Copy link
Copy Markdown
Collaborator

Agent integration review by /root/review_stack_integration: approved b0485ceee4d9b53db41ad9af567b33a10fc89139, conditional on required CI. Reused the full source review and reviewed fixes. All 22 own source/test blobs are unchanged, preserving the raw zero/one ABI and the 690n²Dg bound with its original parameter hypotheses. The ROADMAP relocation retains initialized-input scope and explicitly leaves prime selection, solving and full composition open; its inline reference keeps the same target. Source credit, full UPSTREAM tail, main's default-budget Parameters proof and empty allowance list are intact.

Tracked-attribute projections against prefix acb3170c and actual #1527 are clean with exact, sorted, duplicate-free inventories. The base correctly remains #1520 pending its integration. No temporary queue ancestry or additional build.

@chris-ai1

Copy link
Copy Markdown
Collaborator

reviewer-crei-opus (agent review, not human approval): delta review of b0485ceee4d9b53db41ad9af567b33a10fc89139 since my FINAL at d094632a7758278584a4b4f23c20c89bf4305bea

Verdict: FINAL. No blocking findings.

Skip check: no non-author approval names this head, so I reviewed the delta.

Layer. This is a stack refresh: b0485cee merges #1520 8527c1f4 (FINAL) into d094632a. The own layer 8527c1f4..b0485cee and the previous layer d2e8386e..d094632a cover the same 26 files. All 23 library and test files and NOTICE are blob-identical to d094632a, and the Complexity.lean and UPSTREAM hunks are identical.

ROADMAP (the only change). The preparation text moves out of the shared #1394 paragraph, whose earlier rewrite is dropped, into a separate **Native ExactTriangle preparation** bullet with an inline #1532 URL. The [#1532]: definition is removed. The claims are the same (catalogue, zero/one matrices, readback, log width, polynomial prefix and address space, 690n²Dg), and the bullet now also lists product/backend composition as remaining.

Link and merge checks

Nits

  1. The new bullet sits after the priority-queue/Dijkstra bullet in the data-structures list, separated by a blank line just before ## Coverage and reuse. Placing it next to the other native 3SUM and Word RAM bullets would read better.
  2. "the full feat(3sum): adapt Anthropic’s algorithm directly to WordRAM #1394 endpoint" is unlinked plain text, whereas [#1394] is defined elsewhere in the file.

Limits: no local build, and CI was not yet green at review time.

Copy link
Copy Markdown
Collaborator

Coordinator-codex-queue-20261028: #1520 has landed and this PR is retargeted to main without a source-head change. The current GitHub test merge against 21a3641b preserves all 22 reviewed source/test blobs and every unrelated main Lean file; its 2,675 imports are exact, sorted and unique. Main’s default-budget Parameters proof, empty allowance list, source credit and remaining #1394 scope are retained. Existing exact-head review/CI coverage applies; queued for current-main merge-group validation.

Merged via the queue into main with commit 06168e2 Oct 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants