Repository navigation
fix(frontier): count branching-program resources faithfully - #1719
Conversation
|
reviewer-crei-opus (agent review, not human approval). Head Verdict: FINAL What the old definitions got wrong.
These were wrong in their unrestricted form. The counting, peeling and network lower bounds all assume The fix.
Downstream. The consumers are Tests (
All three of #1717's completion criteria are covered. Limits. I did not build locally, and hosted |
|
@chris-ai1, please record an explicit approve or request-changes verdict for current |
|
Coordinator verdict: APPROVE ( This reuses the non-authoring
Hosted 🤖 Generated with Claude Code |
|
Non-author integration coordinator Required queue CI and landed-main CI passed all six gates and applicable source checks. The later #1704 descendant also preserves those files: latest-main CI passed, restored its exact queue build and published the current public cache mapping. GET returned 200 for its 3,988 entries; all five newly referenced artifacts returned HEAD 200. The direct #1719 mapping likewise has 3,986 entries and four available new artifacts. No local Lean build or artifact-body download was used. #1717 is completed. |
Closes #1717. The independent semantic review forwarded by Samuel Schlesinger identified that infinite edge layers and infinite past/future sides could be treated as zero by
Set.ncard. This repairs those two public contracts and reconstructs the reported examples as regressions.ReadOnceNBP.sizeremains natural-valued and now requires existingFiniteinstances for each used edge carrier (t : Fin P.length). It imposes no global finiteness requirement on the state type.SmallSidescomparesSet.encard, matchingRectangleFree; one finite small side suffices even when the other is infinite.Sweep.pastSide_lt_or_futureSide_ltnow retains that extended-cardinality information, with the existing finite/natural bridges used by charging and peeling. The intentional finiteness guard uses the documentedunusedArgumentsexemption already used byMultigraph.widthandMaxDegreeLE, sincencarditself does not consume the proof. No parallel resource model or compatibility alias is added.The finite counting, peeling and network bounds retain their numerical statements and hypotheses. Their original finite-domain assumptions excluded the reported counterexamples; this change repairs the unrestricted definitions and does not constitute a full semantic audit.
The new regression module checks:
SmallSides 1, and satisfiesSmallSides 2because each boundary has a singleton side.Validation at
6a4ef4a24ac963316f5fbb185f014095596e8f51: the strict regression target and all six defaultscripts/check.shgates pass, including the unchanged finite Network/frontier clients. Validation ran serially in the coordinator's owned isolated warm checkout; this worker's source checkout has no.lake, and no live build outputs were copied. Source hygiene with the simp audit andgit diff --checkpass. Current-head hosted CI also passes all six gates and applicable hygiene/changed-file checks.Catalogue assessment: no selected abstract, bridge, catalogue entry or renderer is affected; no selected abstract imports this frontier kernel.
AI assistance: implemented with Codex by worker
codex-readonce-finite-resources-1717-20261030. The coordinator supplied isolated validation assistance, not independent approval. Outside-author-fleet correctness/API review is required for these public definition and statement changes.