Repository navigation
feat(Foundations): correction atoms with an incoming gate and the incoming cap - #1724
Conversation
First slice of cslib-community#1721 (Phase 4 of cslib-community#1444, idea 6 of cslib-community#474), following the OpenAI preprint (2026-09-23), Sections 5.1-5.2: the normalized dense atom 1{Yt(y)} k(d) R / c(q) has conditional mean exactly k(d) (Lemma 5.1), is bounded by 2|k(d)|, and has fewer than K nonzero entries per row on every draw (Lemma 5.5). The bin weights telescope to a partition of unity (5.6), (5.7). The row-gate failure bound is extracted from le_columnDetector as card_filter_rowGate_lt_one_mul_le and reused by both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…oming cap Second slice of cslib-community#1721 (Phase 4 of cslib-community#1444, idea 6 of cslib-community#474), following the OpenAI preprint (2026-09-23), Sections 5.1, 5.3 and 5.5: the correction atom 1{Yt(y)} Q(d) R T_y / c(q_y) g0(y) has conditional mean exactly Q(d) g0(y), including zero multipliers (Lemma 5.3); it is bounded, has fewer than K nonzero entries per row and fewer than K_c per column on every draw (the incoming cap, (5.18) and Lemma 5.6). Adds the normalization principle, a Markov bound for retained members of a sparse set, rank stability (5.4), nested affine boxes and the joint retention probability at two rates, and the dense atom identity for affine channels at two rates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
reviewer-crei-opus (agent review, not human approval; advisory: same session as the authoring workers). Full review of own commit Verdict: FINAL Lemma 5.3,
Against the source:
Column cap, (5.18) and Lemma 5.6.
Cross-rate channels.
Rank stability, (5.4). Locators, checked against the paper text: (5.4) p. 20, (5.5) p. 21, (5.12)–(5.14) and Lemma 5.3 pp. 23–24, (5.18) and Lemma 5.6 p. 27. Tests are nonvacuous:
Provenance. The OAI Non-blocking nits / follow-ups.
Limits. I did not build locally, and hosted |
edemaine
left a comment
There was a problem hiding this comment.
reviewer-codex-edemaine — APPROVE at 571d5b1e9bb2c2731980eb1e7d133665fd806e42 (independent agent correctness/API review, not human approval). Read the complete seven-file own layer above approved #1723; that parent is unchanged.
Product conditioning correctly models independent start/terminal seeds. The incoming-count bound holds for every terminal set; combining its quarter-failure bound with the row gate's gives mean product gate ≥ 1/2 without assuming gate independence. Normalization handles zero entries/multipliers correctly. The column cap, rank stability and cross-rate affine count/identity statements match their hypotheses. The row-support theorem deliberately counts rank-retained columns; a global support conclusion additionally needs usage-channel nesting.
Checked the pinned OpenAI2026LogSpace manuscript, printed pp. 9, 20–24, 27 and 35. The parameterized cutoffs, weaker sufficient constants and exact-support scope are clearly distinguished from the later approximate access/port contract. Concrete normalization, closed-gate, identity, rank and two-rate affine examples are meaningful. No blocking findings or curated-abstract impact; the recorded shared-lemma refactors remain nonblocking follow-ups.
git diff --check passes. No local Lean build; author reports all six local gates passing. At inspection, exact-head Lean CI is running and title CI passes; required hosted validation remains before integration. Live head rechecked before posting.
|
Coordinator |
SamuelSchlesinger
left a comment
There was a problem hiding this comment.
Coordinator codex-coord-20261029-1732 — APPROVE the validated coordinator fix at 4979a5bc4b078ff09877363da79c624ec6ff41a5 (agent review, not human approval). This uses AGENTS.md's validated coordinator-fix rule for an ordinary current-main merge, reusing the independent full correctness/API/source approval at 571d5b1e.
Exactly seven own paths and every feature-added/removed line are retained. All six reviewed Lean blobs/modes are identical; the aggregate and unrelated main content are preserved. The new parent is actual landed 473efd77. No public mathematical meaning in this PR's own layer changes. Original authorship and source distinction are retained; no selected-abstract/rendering impact.
All six local gates, hygiene, changed-file/tidy and documentation configuration pass at this revision. Fresh source CI and required actual-prefix merge-group CI remain before integration.
|
Non-author integration coordinator Required queue CI and landed-main CI passed all six gates and applicable source checks. Main restored the exact queue build and published the public cache mapping: GET 200, 3,998 entries, with HEAD 200 for all seven newly referenced artifacts. No local Lean build or artifact-body download was used. Exact-support caps and the affine two-rate client retain their stated hypotheses; approximate access, the full threshold package, assembly and machine/resource obligations remain open in #1721 and #1444. |
Part of #1721 (Phase 4 of #1444).
This is slice 2 of the estimator: correction atoms with an incoming gate (idea 6 of #474). A correction atom represents a correction entry
Q(G x y / f) · g₀(y)as the conditional mean of a bounded table. On every draw the table also has fewer thanK_cnonzero entries per column. The later error estimates (Lemma 5.7, Lemma 7.3) need that bound to sum over the sources of a column. The PR also closes the cross-rate gap that slice 1 left (risk 2 in #1721) for the affine channels.This is new mathematics for the library, following the OpenAI preprint (
[OpenAI2026LogSpace], rev7ef5c0cc, unrefereed), §§5.1, 5.3 and 5.5. Statements and names are ours. Only the paper text was read; no OAI Lean code was used.Stacked on #1723 (approved at
3c349e9bf). The stack is needed because this PR reusescard_filter_rowGate_lt_one_mul_leandcard_filter_mul_rowGate_ne_zero_ltfrom it. Please review only this PR's own commit,571d5b1e9. It adds files and touches no line of #1723.Main statements
Complexity/Foundations/Probability/CorrectionAtom.lean(415 lines)A draw is a pair
d = (s, t):sseeds the start channelX, andtseeds the terminal channels (Yfor ranks,Ytfor usage).expect_correctionAtom(Lemma 5.3, including zero multipliers). Hypotheses:Q v ≠ 0 → h v = 1;ρ, τ ∈ [0, 1], withρ = 1throughη > 0andτ = 1throughτ₀ ≥ 0;I v r = 0forv ≤ e;0 < f, and rowxofGis nonnegative with mass≤ M;#{t | Yt t y ∧ Y t w} ≤ c f #{t | Yt t y}, and the start pair bound#{s | X s x ∧ X s w} ≤ p #{s | X s x};g₀ y ≠ 0 → p · #{w | e < G w y / f} ≤ B(the preprint's (5.2) in count form);K ≥ 4 (1 + c M / η)andK_c ≥ 4 (1 + B).Conclusion:
𝔼 d ∈ Sx ×ˢ Sy, correctionAtom … d x y = Q (G x y / f) * g₀ y.abs_correctionAtom_le:|F| ≤ 2 |Q (G x y / f)| |g₀ y|.incomingGate_eq_zero(the cap, Lemma 5.6 proof): ifτvanishes fromg ≤ 1on, andK_cretained sources have score≥ 1, then the gate is0.card_filter_correctionAtom_col_ne_zero_lt((5.18), Lemma 5.6). IfI v r = 1wheneverQ v ≠ 0andρ r ≠ 0, then on every draw#{x ∈ X s | F(x, y) ≠ 0} < K_c.card_filter_correctionAtom_row_ne_zero_lt: on every draw,#{y ∈ Y t | F(x, y) ≠ 0} < K.General statements:
Finset.expect_mul_div_clip_eq(the normalization principle, §5.1): if a gateγ ∈ [0, 1]is below one on at most half ofS, then𝔼_S [m γ / c(𝔼_S γ)] = m.Finset.card_filter_le_card_filter_mul_le(Markov):#{s ∈ S | K ≤ #{w ∈ D | X s w}} · K ≤ #S (1 + p #D)under the pair bound.Matrix.card_filter_incomingGate_lt_one_mul_le: the incoming gate fails on at most a(1 + p #D) / K_cfraction of the draws.Complexity/Foundations/Data/Finset/KthLargest.lean(+36)kthLargest_le_kthLargest_addandabs_kthLargest_sub_kthLargest_le:|rank_k h₁ − rank_k h₂| ≤ εwhen the values differ by at mostε ≥ 0. This is (5.4); Lemma 5.7 in slice 3 will use it. These lemmas need the light importMathlib.Algebra.Order.Group.Abs.Cross-rate channels (risk 2 of #1721)
RetentionChannel.lean(+27):affineRetains_of_le: nested boxes, so a smaller side retains a subset with the same seed.dens_affineRetains_and_affineRetains: forw ≠ y, the joint retention probability with sidesL₁,L₂is(L₁/P)^H (L₂/P)^H.Complexity/Probability/PairwiseIndependentHash/AtomChannels.lean(117 lines):card_filter_and_le_of_dens_le: a conditional probability bound as a count.card_affineRetains_and_affineRetains_le: the cross-rate pair bound2^H a^H.expect_denseAtom_affineRetains: the dense atom identity at two rates. The rank channel has side⌈P a⌉and the usage channel has side0 < L_t ≤ ⌈P a⌉.Source → Lean
Printed pages of rev
7ef5c0cc, checked against the paper text.k(d_y)R/q(x,y)has conditional meank(d_y)expect_mul_div_clip_eq|rk_k(v) − rk_k(w)| ≤ sup_z |v_z − w_z|kthLargest_le_kthLargest_add,abs_kthLargest_sub_kthLargest_leI_ϑ(v, ρ)auxScore(withIas a parameter)T_y = 1 − χ_{1/4,1/2}(rk_{K_c}{I(x,y) : X_u(x) = 1})incomingGateq_y = E[h R T_y | X_u(x) = Y_t(y) = 1],F = 1{Y_t(y)=1} Q_at(d_y) R T_y / c(q_y) · g₀(y)correctionPrep,correctionNormalizer,correctionAtomexpect_correctionAtom,card_filter_incomingGate_lt_one_mul_le,card_filter_le_card_filter_mul_leincomingGate_eq_zero,card_filter_correctionAtom_col_ne_zero_lt,card_filter_correctionAtom_row_ne_zero_ltaffineRetains_of_le,dens_affineRetains_and_affineRetains,card_affineRetains_and_affineRetains_le,expect_denseAtom_affineRetainsDifferences from the source
ṽ,ρ̃((5.17), Lemma 5.5, second part). These are part of the implementation interface, so they belong to Phase 6.K, K_c ≥ 4(…), so that each gate fails on at most a quarter of the draws, givingq ≥ 1/2. The preprint uses1/8per gate andq ≥ 3/4.Q,h,ρ,τ,Icarry only the threshold properties each statement uses. The preprint's cappedQ_atand its switchesχare slice 3.p · #D ≤ B, the count form of (5.2) withu ≤ fabsorbed. It is assumed only wheng₀(y) ≠ 0, as in the source.expect_denseAtom(feat(Foundations): dense stochastic atoms and their identity #1723) still has its own copy of the argument. Refactoring it would edit feat(Foundations): dense stochastic atoms and their identity #1723's approved lines, so that is left for a follow-up.Tests
ComplexityTests/CorrectionAtom.lean(217 lines):(1, 1, 0), whose mean is2/3;K_c = 2;< 2) and row (< 3) support on every draw of arbitrary channels;½-walk with multiplier3, with mean exactly3/2;RetentionChannels, and its instance with the affine channels over𝔽_Pon both sides for every primeP;ComplexityTests/AtomChannels.lean(66 lines):2/9over𝔽₃;x ↦ x + 1on𝔽₅(sides3and1,K = 8002), with value2.Size
CorrectionAtom.leanAtomChannels.leanKthLargest.leanRetentionChannel.leanValidation
At
4979a5bc, all six defaultscripts/check.shgates pass in the isolated worktree, along with hygiene--check-simp, changed-file/tidy checks and documentation configuration. The normal main merge preserves every reviewed own-layer feature line and all six Lean payloads/modes. Refreshed hosted and required queue checks remain before integration; the integration record owns final evidence. No selected abstract, bridge, endpoint or renderer is affected.Review
Reuse the independent correctness/API/source approval for the unchanged own layer. The current-main merge is a validated coordinator fix with no change to this PR's public mathematical meanings.
AI assistance: written by Claude Code (Claude Opus 5.5) as worker
worker-crei-dc679113-1444p4for coordinatorcoordinator-crei-dc679113, at crei's request.Codex performed the normal main integration and validation, preserving the reviewed Lean sources and original authorship. These are agent reviews, not human approval.
🤖 Generated with Claude Code