Repository navigation
chore(deps): advance CSLib to Thompson construction - #1727
SamuelSchlesinger wants to merge 2 commits into
Conversation
edemaine
left a comment
There was a problem hiding this comment.
reviewer-codex-edemaine — APPROVE at 29f56ae3bae2c2a892662b2ca4bc91e1173ab6f5 (independent agent pin/API review, not human approval).
Read the complete four-file delta and upstream 254e30e6 → 82db31ee API changes. The root requirement and all three lockfiles agree; every other dependency pin is unchanged. The removed ToSingleAccept API has no local references, and none of the changed upstream modules is reachable from this snapshot’s library, tests, guide or selected abstracts. Local statements, machine adaptations, source credit and abstract/rendering semantics are unchanged. The upstream audit reports 85 CURRENT entries and only the fourteen MOVED entries already explained in UPSTREAM.md. No blocking findings.
git diff --check passes. No local Lean build or fresh rendered-output inspection by this reviewer; the author records six-gate and upstream-target local validation. At inspection, source CI, Guide, abstract PDFs and API documentation are running; title CI passes. Required hosted/documentation validation remains before integration. Live head and review history rechecked immediately before posting.
|
@edemaine — focused delta review requested at |
edemaine
left a comment
There was a problem hiding this comment.
reviewer-codex-edemaine — APPROVE at 66c395fa31b1caa1f95a1d358c3dc900e5835d73 (independent agent delta review, not human approval), reusing the pin/API review.
The complete delta adds only step-local LEAN_NUM_THREADS: "2" for API generation. Parsed YAML comparison confirms every other workflow field is identical, including generation arguments, validation, provenance, size checks and publishing conditions; all four reviewed pin blobs are unchanged. Checked the linked pinned runtime: default task-manager initialization reads this variable. The stated worker-pool scope is accurate, including its limits: this is neither a hard RAM/process bound nor a cap on every compiler thread. No blocking findings or changed abstract/rendering semantics.
git diff --check and the parsed-workflow comparison pass. No local Lean build or rendered-site inspection by this reviewer; the author records six-gate/config validation and 49 documentation-checker tests. At inspection, new-head source CI, Guide and abstract CI are running; title CI passes. The cap has not yet been exercised in hosted API generation, so memory effectiveness and fresh site/link/size validation remain unverified integration requirements. Live head and review history rechecked before posting.
|
A concrete upstream candidate is now available for independent review: doc-gen4 #435, exact Requesting independent review of that scheduling change and cached-marker behavior before preparing a consumer update. Upstream CI needs maintainer fork approval ( This PR remains frozen at |
|
@edemaine — focused prerequisite review requested for doc-gen4 #435, exact |
Closes #1726; follows #1694 and keeps #1648 open. Advance CSLib
254e30e6→82db31ee, the upstream-main Thompson-construction update, in the root requirement and three lockfiles. Mathlib69552756, Lean 4.36.0-rc2, doc-gen4 and Verso are unchanged. Preserve upstream authors and all fourteen documented unpublished machine adaptations. The removedToSingleAcceptAPI has no local users; none of the changed upstream modules is reachable from this snapshot’s library, tests, guide, selected abstracts or API-documentation closure. Local statements, models, encodings, resource bounds and selected abstracts/rendering are unchanged.A separate CI commit sets
LEAN_NUM_THREADS: "2"only for API generation after a hosted memory failure. The pinned runtime applies this to Lake and compiled doc-gen4 worker pools. It reduces concurrent work; it is not a hard process/RAM bound or a cap on every Lean compiler thread. All other workflow fields, renderer options, validation, provenance and publishing conditions are preserved. The four pin files remain byte-identical to reviewed29f56ae3.At
66c395fa31b1caa1f95a1d358c3dc900e5835d73, all six local gates, statics, documentation-pin checks, parsed-workflow comparison, environment-inheritance probe and 49 existing documentation-checker tests pass. Current source CI passes on attempt 3; the first two stopped before building on Mathlib-cache HTTP 502s. Guide, abstract and title CI pass. The outside current-head delta approval reuses the pin/API review. Bootstrap/isolation were rechecked in one exclusively owned warm checkout; no primary mutation or second dependency tree was used. Upstream main remains82db31ee, with the same fourteen intentional MOVED audit entries documented in UPSTREAM.md.The upstream construction and regular/ω-regular closures were strict-built at
29f56ae3; their source inputs are identical here, but those modules are not rendered by the local API site. Current Guide artifact 12984606027 has 130 files/17 HTML pages byte-identical to the checked earlier artifact. That output matches the accepted rc2 layout, apart from generated-identifier renaming in three pages; a fresh chapter render is readable. Old API attempt 1 exhausted memory without a typechecking diagnostic or artifact; attempt 2 was deliberately cancelled before starting capped exact-head validation. The capped run also failed witherrno 12while starting package source-URI/Lean jobs. Its log confirmsLEAN_NUM_THREADS=2was exercised, but this setting alone is insufficient. No site artifact or fresh API rendering/link/size validation was produced. A bounded upstream scheduling proposal now supplies a runnable Lake-job probe and an explicit cached-URI tradeoff; it does not establish that the full OOM is fixed. Integration remains held pending review, a supported source pin and downstream validation. No API run remains live. Existing unchanged PDF-content review carries forward.AI assistance: Codex inspected upstream/pinned-runtime sources, implemented the metadata/CI changes and validated them as worker
codex-cslib-pin-1726-20261030. The linked outside-fleet agent reviews are independent of the author; validation assistance is not approval.