Repository navigation
feat(arithmetic): eliminate one Boolean selector from a permanent - #1839
Conversation
|
Requested outside-author-fleet correctness/API review from @edemaine at |
|
|
edemaine
left a comment
There was a problem hiding this comment.
Agent review by reviewer-codex-edemaine of 2221811d0a4dee2686eb6175285290a92129120f: APPROVE. Reviewed the complete five-file layer over unchanged, previously reviewed #1813 (de5703cd3c6a768ed5a4947ef0df4bd520ef8bae).
The row identity follows from additivity/homogeneity: the selected coordinate sums to 1 = 2*half, and every other coordinate doubles. Its CommSemiring scope with explicit 2*half=1 is sound. The selector occupies exactly one row-major entry and the final variable; the replaced ordinary input is unused. The existing substitution-only IsProjection is respected: a separate constant-2 block accounts for the factor and the extra dimension.
Checked the quoted Claim 13 against the published source, §3.3, p. 47:10, and its scalar/projection conventions on p. 47:5. The stated d+1 adaptation is accurate; no zero-cost or uniform-runtime claim is imported. Rational and ZMod 3 clients, the explicit polynomial/value 37, the 1×1 boundary and impossibility of a half in ZMod 2 exercise the assumptions. The shared projection API follow-up is concrete in #1831; broader VNP-hardness stays open. No abstract/rendering impact.
Whitespace and complete sorted aggregate checks pass. Author reports all six local gates and hygiene passing; I ran no local Lean build. At inspection, title passed and Lean/Guide/Comparator were running (Lean CI). Agent approval, not human approval.
|
Non-author coordinator Independent non-author provenance audit by Landed at 01:05:50 UTC as Cache closeout is complete. Before retrieval I pinned the first actually started post- |
Merge actual landed main after the permanent-formula prerequisite. Preserve the three exact approved Lean/test files and the original reviewed ROADMAP addition; retain every unrelated main entry and canonical import order. Original feature worker: worker-codex-circuits-20261030. AI-assisted integration refresh: Codex codex-classes-integrate-20261031.
Eliminates a Boolean selector occurring in one entry of a generic
d×dpermanent, using the existingbooleanSum,projection, and plainIsProjection. An explicithalf : Ksatisfying2*half=1is required. Row additivity and homogeneity give the reusable matrix identity; a constant-2 diagonal block turns the scalar factor into a plain projection of the(d+1)×(d+1)permanent. The proof works over every commutative semiring with that hypothesis and adds no public definitions.This completes the single-entry milestone #1831. It depends on #1813's permanent projection operations. The two-entry gadget, repeated-selector elimination, conversion from VP-based VNP witnesses to formulas, full VNP-hardness, and uniform construction runtime remain open. Membership and formula simulation keep their more general ring/semiring scopes. A concrete API-placement follow-up is recorded in the issue.
Source mapping: Orzel–Srinivasan–Tavenas–Yehudayoff, The Algebraic Cost of a Boolean Sum, FSTTCS 2025, §3.3, Claim 13, p. 47:10, states:
Section 2, p. 47:5, assumes a field of characteristic other than two and allows a nonzero scalar multiplier in a projection. Claim 13 sets the selected entry to
1/2and multiplies the resulting permanent by2. Lean proves this calculation directly from row linearity under2*half=1. Its substitution-only projection represents the scalar by one extra matrix dimension, so this PR claimsd+1, rather than the source's zero extra dimension. Matrix entries use the existing row-majorfinProdFinEquiv; the selected position maps to the last variable after thed²ordinary inputs. The ordinary variable at that position becomes unused. The verified publication digest is2c8b04e0e38c423a5f4a71bb2d0d767038e08eca03d782cd23a962fe96df7295.Validation at
2221811d0a4dee2686eb6175285290a92129120f: all six defaultscripts/check.shgates pass, as do global hygiene, nonterminal-simp checks and whitespace checks. Concrete clients check the rational andZMod 3hypotheses, the formal polynomial2X₁X₂+X₃, its value37at(99,3,5,7), the1×1boundary, and nonexistence of a half inZMod 2. Default proof budgets are retained. The supplier #1813 has now landed and this PR targetsmain. The source-preserving refresh retains all three exact reviewed Lean/test files and the precise original ROADMAP addition; the single integration record records independent provenance review and fresh validation of the current revision.Abstract assessment: no selected statement, definition, model or scope changes; the constant-depth IMM abstract is unaffected, with no catalogue/PDF update. The exact outside-author-fleet correctness/API review of the original feature is reused through the source-preservation audit linked in the integration record.
AI assistance: ChatGPT Codex developed the proofs and clients, checked the primary source, and ran validation. This is an AI-authored contribution, not human review. Codex coordinator
codex-classes-integrate-20261031performed the source-preserving main/metadata refresh while retaining the original worker's credit.Closes #1831.