Repository navigation
doc(hashing): correct CLRS page locators for uniform probing - #1843
Conversation
Checked against the third edition (pp. 269-277). Section 11.4 begins on p. 269, Corollary 11.7 is stated on p. 275, and the fact that a search reproduces the insertion probe sequence is in the proof of Theorem 11.8 on p. 276. Statements and proofs are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015DLg8kwPs8yi7ePPdtoNvG
|
|
edemaine
left a comment
There was a problem hiding this comment.
Agent review by reviewer-codex-edemaine (non-author): APPROVE at a38b1d1.
Checked the complete two-file documentation delta against CLRS, third edition: §11.4 begins on printed p. 269, Corollary 11.7 is on p. 275, and the insertion/search probe-sequence argument is in the proof of Theorem 11.8 on p. 276. Verified these pages in the textbook PDF and read the affected Lean statements and surrounding representation semantics. Both files are identical outside comments; no mathematical, API or curated-abstract change.
Validation: diff whitespace check passes; canonical import aggregate unchanged. Author reports focused builds and hygiene checks. At inspection, title CI passed; Lean, Guide and Comparator workflows were running. No local Lean build performed. This is agent review, not human approval.
Post-merge audit of #1709 by
reviewer-claude-e6cf7b0d-3(Claude Code, Opus) found four page locators for CLRS, 3rd edition, that do not match the book. I checked them against the printed Chapter 11 pages (253–284). This PR fixes only the locators. Statements, proofs and tests are unchanged.pp. 270–277becomespp. 269–277, and the Section 3 header changes to match.TableRep.probeCount_tableInsert_of_isSomecited "Section 11.4, p. 275". The fact it supports, that a search for a key repeats the probe sequence used to insert it, is the first line of the proof of Theorem 11.8 on p. 276.These locators already match the book: uniform hashing (p. 271), double hashing (pp. 272–274), Theorem 11.6 (pp. 274–275) and Theorem 11.8 (p. 276). The textbook statements also match their Lean mappings, and #1709's statements need no change. The CLRS locators in
ChainedHash(Theorem 11.3 and Corollary 11.4 in §11.3.3) are also correct, so that file is not touched.Validation: both edited modules build locally, and
scripts/check_hygiene.pyandgit diff --checkpass. Hosted CI covers the full gates.Curated abstracts: no impact.
AI assistance: Claude Code (Opus) checked the source and edited the docstrings, as part of a post-merge audit for
coordinator-claude-e6cf7b0d. This change needs outside-fleet review. This is not human review.🤖 Generated with Claude Code
https://claude.ai/code/session_015DLg8kwPs8yi7ePPdtoNvG