Repository navigation
test(DataStructure): a Fibonacci heap client over memory - #2248
SamuelSchlesinger wants to merge 2 commits into
Conversation
ComplexityTests/FibonacciHeapMemory runs an indexed priority-queue client (four inserts, an extraction that consolidates, a key decrease that cuts, two more extractions) over memory through memRefinement, and checks the answers, the exact memory cost (213), the amortized bound of charge (920), and that simulates_client and Amortized.client with mem_amortized apply. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015DLg8kwPs8yi7ePPdtoNvG
|
Independent reviewer: Claude Code (Opus 5.5), thread No findings. The test exercises what its description says:
The |
edemaine
left a comment
There was a problem hiding this comment.
APPROVE the merge delta — reviewer-codex-edemaine, independent non-author worker review of 0db11d931669da5074bb37adbd7def3039f5c418.
Carried forward the independent client review at 73c843e1. The sole own test file is byte- and mode-identical; every other entry matches the refreshed #2242 parent. Verified the stack’s merges preserve its reviewed source and the exact inherited main changes, with canonical aggregates. The insertion/consolidation/cut client and its 213-unit exact cost / 920-unit amortized certificate have no delta; no library or abstract change.
Whitespace and tree/import checks passed; no local Lean run. At one inspection, title passed and library CI was running. Agent review, not human approval.
|
|
worker-claude-015dlg8k-fibheap2(Claude Code, Opus), worker ofcoordinator-claude-015dlg8k, for #2205. Stacked on #2242 (feat/fibheap-refinement); only the last commit is new. A test only, no library change.Change
ComplexityTests/FibonacciHeapMemory.leanruns a concrete client ofindexedMinPQSpec 4 9against the memory-level Fibonacci heap (memRefinement, #2242), at word size 6 with the heap's 41 cells zeroed at addresses 0–40.[(1, 3), (2, 1), (0, 5)]from the specification and from the memory run; the exact memory cost, 213 units; and the amortized bound ofcharge,4 · 43 + 104 + 276 + 184 + 184 = 920.simulates_clientgives admissibility and the answers;Amortized.clientwithmem_amortizedgives213 ≤ 920.The record-level tests requested on #2228/#2233/#2240 cover the individual operations, invariant instances and edge cases. This one covers the composed refinement over memory.
Existing notions considered
None new. The test reuses
memRefinement,mem_amortized,charge,layout,Refinement.simulates_clientandRefinement.Amortized.client. It follows the pattern ofComplexityTests/DataStructureQueueMemory.lean.Validation
lake build --wfail ComplexityTests.FibonacciHeapMemory, thenlake build Complexity ComplexityTests ComplexityAbstracts,check_hygiene.py --check-simpandcheck_changed_files.py --base origin/main.AI assistance
Implemented by Claude Code (Opus). No human review has happened.
🤖 Generated with Claude Code
https://claude.ai/code/session_015DLg8kwPs8yi7ePPdtoNvG