Skip to content

Add configurable ports from tfvars - #30

Merged
The0mikkel merged 6 commits into
developfrom
feat/configurable-additional-ports
Aug 2, 2026
Merged

The0mikkel merged 6 commits into
developfrom
feat/configurable-additional-ports

Conversation

@The0mikkel

Copy link
Copy Markdown
Member

Allow configuring additional ports for Traefik, such as for static TCP challenges, and allow adding additional trusted IPs for Traefik, for example to trust Cloudflare proxy headers.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the cluster’s Traefik configuration surface so operators can configure additional TCP entrypoints/ports and additional trusted IP CIDRs via tfvars, aligning the Terraform layer with more flexible ingress/LB setups (e.g., TCP challenges, proxy header trust). It also adjusts the Traefik HelmChartConfig access log configuration and refines the Filebeat input metadata.

Changes:

  • Add traefik_additional_ports and traefik_trusted_ips to the tfvars templates and ctfp.py variable allowlist.
  • Introduce Terraform variables/locals to map user-facing {internalPort, externalPort} objects into kube-hetzner’s expected {port, exposedPort} shape.
  • Update Traefik Helm chart values for access logs and tweak the Filebeat input id.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
template.automated.tfvars Adds new Traefik port/trusted-IP knobs to the automated tfvars template.
cluster/tfvars/template.tfvars Adds the same Traefik knobs to the cluster tfvars template.
ctfp.py Allows the new tfvars keys to be recognized/propagated by the CLI/tooling.
cluster/variables.tf Defines new variables and a local mapping list for Traefik additional ports and trusted IPs.
cluster/kube.tf Wires the new variables into the kube-hetzner module inputs.
ops/traefik.tf Adjusts Traefik HelmChartConfig values (access logs) and Filebeat input metadata.
Suppressed comments (1)

cluster/variables.tf:262

  • Minor grammar/capitalization issues in the variable description (e.g., "Trusted"/"Loadbalancer"). Since this is user-facing documentation, it’s worth tightening for clarity and consistency.
  description = "List of additional Trusted IPs to pass to Traefik as CIDR notation. Loadbalancer IPs are automatically added to this list. If you want to add additional trusted IPs, enter them here as a list of strings."

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ops/traefik.tf
Comment thread cluster/kube.tf
Comment thread cluster/variables.tf
Comment thread template.automated.tfvars Outdated
Comment thread cluster/tfvars/template.tfvars Outdated
Base automatically changed from feat/25/configurable-replica-count to develop August 2, 2026 21:01
@The0mikkel
The0mikkel merged commit ac1254f into develop Aug 2, 2026
4 checks passed
@The0mikkel
The0mikkel deleted the feat/configurable-additional-ports branch August 2, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants