Repository navigation
Add configurable ports from tfvars - #30
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the cluster’s Traefik configuration surface so operators can configure additional TCP entrypoints/ports and additional trusted IP CIDRs via tfvars, aligning the Terraform layer with more flexible ingress/LB setups (e.g., TCP challenges, proxy header trust). It also adjusts the Traefik HelmChartConfig access log configuration and refines the Filebeat input metadata.
Changes:
- Add
traefik_additional_portsandtraefik_trusted_ipsto the tfvars templates andctfp.pyvariable allowlist. - Introduce Terraform variables/locals to map user-facing
{internalPort, externalPort}objects into kube-hetzner’s expected{port, exposedPort}shape. - Update Traefik Helm chart values for access logs and tweak the Filebeat input
id.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
template.automated.tfvars |
Adds new Traefik port/trusted-IP knobs to the automated tfvars template. |
cluster/tfvars/template.tfvars |
Adds the same Traefik knobs to the cluster tfvars template. |
ctfp.py |
Allows the new tfvars keys to be recognized/propagated by the CLI/tooling. |
cluster/variables.tf |
Defines new variables and a local mapping list for Traefik additional ports and trusted IPs. |
cluster/kube.tf |
Wires the new variables into the kube-hetzner module inputs. |
ops/traefik.tf |
Adjusts Traefik HelmChartConfig values (access logs) and Filebeat input metadata. |
Suppressed comments (1)
cluster/variables.tf:262
- Minor grammar/capitalization issues in the variable description (e.g., "Trusted"/"Loadbalancer"). Since this is user-facing documentation, it’s worth tightening for clarity and consistency.
description = "List of additional Trusted IPs to pass to Traefik as CIDR notation. Loadbalancer IPs are automatically added to this list. If you want to add additional trusted IPs, enter them here as a list of strings."
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow configuring additional ports for Traefik, such as for static TCP challenges, and allow adding additional trusted IPs for Traefik, for example to trust Cloudflare proxy headers.