Skip to content

pick owner address distinct from payout #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julian-CStack merged 3 commits into from
Sep 25, 2026
Merged

pick owner address distinct from payout #1453

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86b9ec9
pick owner address distinct from payout and voting addresses
levoncrypto Sep 25, 2026
19add82
allow owner address to equal voting address
levoncrypto Sep 25, 2026
1324e37
Merge branch 'staging' into masternode-payout-ui
julian-CStack Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions lib/wallets/wallet/impl/firo_wallet.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,20 +1020,21 @@ class FiroWallet<T extends ElectrumXCurrencyInterface> extends Bip39HDWallet<T>
);
}

bool isUsableOwner(Address? address) =>
address != null &&
address.value != collateralAddress &&
address.value != payoutAddress;

Address? ownerAddress = await getCurrentReceivingAddress();
const maxOwnerAttempts = 32;
for (
var i = 0;
i < maxOwnerAttempts &&
(ownerAddress == null || ownerAddress.value == collateralAddress);
i++
) {
for (var i = 0; i < maxOwnerAttempts && !isUsableOwner(ownerAddress); i++) {
await generateNewReceivingAddress();
ownerAddress = await getCurrentReceivingAddress();
}
if (ownerAddress == null || ownerAddress.value == collateralAddress) {
if (ownerAddress == null || !isUsableOwner(ownerAddress)) {
throw Exception(
"Could not derive owner address distinct from collateral address.",
"Could not derive owner address distinct from collateral and payout "
"addresses.",
);
}

Expand Down
Loading