Repository navigation
Build the browser template on any docker base image - #924
Merged
Merged
Conversation
Drukbox builds browser.sh on the default image of its docker provider, and the deployment sets that image. A compose install leaves drukbox's stock image there, which has no Node and no druks user, so npm install exited 127. A deployment can also set the sandbox image, which has both. browser.sh installs Node 22 from nodesource and adds the druks user again. Both steps also pass on the sandbox image: gpg overwrites the nodesource keyring, and useradd runs only when the user is missing. The browser PR check builds browser.sh on both images.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #887.
Drukbox builds
browser.shon the default image of its docker provider, and the deployment sets that image. A compose install leaves drukbox's stock image there, with no Node and nodruksuser. A deployment can also set the sandbox image, which has both.browser.shexpected the sandbox image, so the browser template failed on every compose install.browser.shinstalls Node 22 from nodesource and adds thedruksuser again. Both steps also pass on the sandbox image:gpg --yesoverwrites the nodesource keyring, anduseraddruns only when the user is missing.browserPR check buildsbrowser.shon both images.