Repository navigation
fix(installer): reserve core IPs outside Docker automatic allocation - #739
Open
sembrestels wants to merge 1 commit into
Open
sembrestels wants to merge 1 commit into
sembrestels wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create dncore_network with subnet 172.33.0.0/16, gateway 172.33.0.1 and dynamic allocation range 172.33.128.0/17. This keeps DNS 172.33.1.2 and Dappmanager 172.33.1.7 outside automatic allocation and matches Dappmanager's companion address-allocation policy.
Existing networks are retained. Legacy allocation settings produce an actionable migration notice after upgrading Dappmanager; the installer does not silently replace an active bridge. Network-creation failures propagate instead of being ignored.
Validation:
Pair with Dappmanager branch fix/separate-static-docker-addresses for the existing-installation migration and recovery tooling. Its operational capacity checks and external-service validation limitations are described in the companion PR text and validation report.