Repository navigation
Conversation
ausias-armesto
approved these changes
Oct 28, 2026
Collaborator
There was a problem hiding this comment.
We need to start thinking about not duplicating code. This same code is in gnosis_vpn-infrastructure and it should be part of the gnosis_vpn-server repository artifacts.
And each deployment model (gnosis_vpn-infrastructure, dappNode, exitOS should download it via a package or similar.
I think it's time to create an issue to handle this
Collaborator
Author
There was a problem hiding this comment.
I agree, too many duplications.
| `wg-quick` runs the script from `PostUp`/`PreDown` in `wggvpn.conf`. It is a port of the | ||
| `wg-hooks.sh` + `iptables.rules` pair from the exit-node appliance image (`gnosis_vpn-exit_os`). | ||
| The appliance version can't be used as-is, because a DAppNode package never sees the host's | ||
| network namespace (see "Known limitations" below). |
Collaborator
There was a problem hiding this comment.
Based on my previous comment, I still think that there are too many similarities that it's worth to join both efforts into one place and make it configurable.
Updated the base image from 'hoprd-pix-test' to 'hoprd'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also: