feat(emoji): toggle beside the alphabet picker — both surfaces - #67
Merged
Merged
Conversation
Placement feedback: the 😀 toggle was IME-only and crowding the editing strip (7 buttons). Mode switches belong with mode controls: - IME: 😀 moves from the editing strip into the Float/Hide top bar (Float | 😀 | Hide). EditingToolbar reverts to a pure edit-action row (its onToggleEmoji param and emoji state helpers are removed). - App mode: new toggle in the StatusBar bottom row, immediately left of the alphabet picker (Windows-style bar convention) — shown only when the engine reports the Emoji alphabet. Same remember/restore logic as the IME, sharing the return alphabet via dasher_ime prefs so toggling in one surface restores correctly in the other. Explicit choice pins the alphabet (same as a picker selection). Refs #61. Signed-off-by: will wade <willwade@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the emoji toggle out of the IME editing strip and adds it to app mode:
Behaviour (shared)
Toggle → Emoji alphabet, remember the previous one; toggle again → restore. The return alphabet lives in the shared
dasher_imeprefs, so toggling in the app and restoring in the IME (or vice versa) works. App-mode toggles pin the alphabet choice like any explicit picker selection.Testing
Refs #61.