Skip to content

guava_fixes - #238

Open
AbhishekKumar9984 wants to merge 1 commit into
data-integrations:developfrom
AbhishekKumar9984:guava_fixes
Open

AbhishekKumar9984 wants to merge 1 commit into
data-integrations:developfrom
AbhishekKumar9984:guava_fixes

Conversation

@AbhishekKumar9984

@AbhishekKumar9984 AbhishekKumar9984 commented Oct 20, 2026 •

Copy link
Copy Markdown

Issue :
Resolved security vulnerabilities (CVE-2023-2976 / CVE-2020-8908) associated with older versions of com.google.guava:guava (13.0.1) pulled in directly and transitively via plugin dependencies.

Root Cause :
pom.xml specified com.google.guava:guava version 13.0.1 (and 31.1-jre in the e2e profile), while CDAP and Hadoop dependencies transitively pulled in older versions of Guava.

Fix :

  • Upgraded com.google.guava:guava from 13.0.1 to 32.0.0-jre via <guava.version>32.0.0-jre</guava.version> in pom.xml and removed the 31.1-jre override from the e2e profile.
  • Excluded transitive com.google.guava:guava from cdap-formats, hydrator-test, cdap-data-pipeline3_2.12, hydrator-common, format-common, hadoop-common, and cdap-e2e-framework.

Testing evidence: https://docs.google.com/spreadsheets/d/1Cw6Z_k3wlks7sAC4-Kg6FTIMRL7-zxLlsJIXvVJLrb8/edit?gid=0#gid=0

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Guava dependency version to 32.0.0-jre and adds exclusions for Guava across multiple dependencies in pom.xml. However, the selected Guava version (32.0.0-jre) is vulnerable to CVE-2023-2976, which is a local information disclosure vulnerability. It is recommended to upgrade to version 32.1.3-jre or later to mitigate this security risk.

Comment thread pom.xml Resolved

@dheeraj-kholia-cs dheeraj-kholia-cs left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepika-lalwani123 deepika-lalwani123 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine overall. One nit inline.

Comment thread pom.xml
<main.basedir>${project.basedir}</main.basedir>
<testSourceLocation>${project.basedir}/src/test/java/</testSourceLocation>
<jackson.databind.version>2.13.4.2</jackson.databind.version>
<guava.version>32.0.0-jre</guava.version>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guava jumps from 13 to 32 with no source changes. Please verify against a Guava-32 CDAP build. Please use Guava >= 32.1.3-jre instead of 32.0.0-jre. 32.0.0 has a known regression (temp dir handling), fixed in 32.0.1. Ideally pin it once in dependencyManagement and add a maven-enforcer requireUpperBoundDeps rule rather than per-dependency <exclusion> blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants