Repository navigation
guava_fixes - #238
guava_fixes#238AbhishekKumar9984 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Guava dependency version to 32.0.0-jre and adds exclusions for Guava across multiple dependencies in pom.xml. However, the selected Guava version (32.0.0-jre) is vulnerable to CVE-2023-2976, which is a local information disclosure vulnerability. It is recommended to upgrade to version 32.1.3-jre or later to mitigate this security risk.
deepika-lalwani123
left a comment
There was a problem hiding this comment.
Looks fine overall. One nit inline.
| <main.basedir>${project.basedir}</main.basedir> | ||
| <testSourceLocation>${project.basedir}/src/test/java/</testSourceLocation> | ||
| <jackson.databind.version>2.13.4.2</jackson.databind.version> | ||
| <guava.version>32.0.0-jre</guava.version> |
There was a problem hiding this comment.
Guava jumps from 13 to 32 with no source changes. Please verify against a Guava-32 CDAP build. Please use Guava >= 32.1.3-jre instead of 32.0.0-jre. 32.0.0 has a known regression (temp dir handling), fixed in 32.0.1. Ideally pin it once in dependencyManagement and add a maven-enforcer requireUpperBoundDeps rule rather than per-dependency <exclusion> blocks.
Issue :
Resolved security vulnerabilities (CVE-2023-2976 / CVE-2020-8908) associated with older versions of
com.google.guava:guava(13.0.1) pulled in directly and transitively via plugin dependencies.Root Cause :
pom.xmlspecifiedcom.google.guava:guavaversion13.0.1(and31.1-jrein the e2e profile), while CDAP and Hadoop dependencies transitively pulled in older versions of Guava.Fix :
com.google.guava:guavafrom13.0.1to32.0.0-jrevia<guava.version>32.0.0-jre</guava.version>inpom.xmland removed the31.1-jreoverride from the e2e profile.com.google.guava:guavafromcdap-formats,hydrator-test,cdap-data-pipeline3_2.12,hydrator-common,format-common,hadoop-common, andcdap-e2e-framework.Testing evidence: https://docs.google.com/spreadsheets/d/1Cw6Z_k3wlks7sAC4-Kg6FTIMRL7-zxLlsJIXvVJLrb8/edit?gid=0#gid=0